mirror of
https://github.com/goauthentik/authentik
synced 2026-04-27 09:57:31 +02:00
ba9e7fe315
* core: add prettier failure on duplicate group names * add db_alias Co-authored-by: Jens L. <jens@goauthentik.io> Signed-off-by: Simonyi Gergő <28359278+gergosimonyi@users.noreply.github.com> * lint * migrate to system migration Signed-off-by: Jens Langhammer <jens@goauthentik.io> * fix error on empty database Signed-off-by: Jens Langhammer <jens@goauthentik.io> * returning a count of 0 still takes 1 row :P --------- Signed-off-by: Simonyi Gergő <28359278+gergosimonyi@users.noreply.github.com> Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens L. <jens@goauthentik.io>
42 lines
1.5 KiB
Python
42 lines
1.5 KiB
Python
# flake8: noqa
|
|
from lifecycle.migrate import BaseMigration
|
|
|
|
SQL_STATEMENT = """
|
|
SELECT "authentik_core_group"."name" AS "name",
|
|
Count("authentik_core_group"."name") AS "name__count"
|
|
FROM "authentik_core_group" GROUP BY 1
|
|
HAVING Count("authentik_core_group"."name") > 1
|
|
ORDER BY 2 DESC,
|
|
1 ASC
|
|
"""
|
|
|
|
|
|
class DuplicateNameError(RuntimeError):
|
|
pass
|
|
|
|
|
|
class Migration(BaseMigration):
|
|
def needs_migration(self) -> bool:
|
|
self.cur.execute(
|
|
"select 1 from information_schema.tables where table_name = 'django_migrations';"
|
|
)
|
|
if not bool(self.cur.rowcount):
|
|
# No django_migrations table, no data to check
|
|
return False
|
|
# migration that introduces the uniqueness
|
|
self.cur.execute(
|
|
"select 1 from django_migrations where app = 'authentik_core' and name = '0056_user_roles';"
|
|
)
|
|
return not bool(self.cur.rowcount)
|
|
|
|
def run(self):
|
|
rows = self.cur.execute(SQL_STATEMENT).fetchall()
|
|
if len(rows):
|
|
for row in rows:
|
|
self.log.error(
|
|
"Group with duplicate name detected", group_name=row[0], count=row[1]
|
|
)
|
|
raise DuplicateNameError(
|
|
f"authentik 2025.12 forbids duplicate group names. For a list of duplicate groups, see logging output above. Please rename the offending groups and re-run the migration. For more information, see: https://version-2025-12.goauthentik.io/releases/2025.12/#group-name-uniqueness"
|
|
)
|