From 522f55f81e4cf2bb7aa3674c2c548c9aa5c012cb Mon Sep 17 00:00:00 2001 From: Alezander9 Date: Sat, 5 Jul 2025 20:24:27 -0700 Subject: [PATCH 1/3] fix-screenshot-test --- tests/ci/test_browser_session_screenshots.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/ci/test_browser_session_screenshots.py b/tests/ci/test_browser_session_screenshots.py index e07fdda8f..2ba32f10d 100644 --- a/tests/ci/test_browser_session_screenshots.py +++ b/tests/ci/test_browser_session_screenshots.py @@ -184,9 +184,12 @@ class TestHeadlessScreenshots: browser_sessions.append(session) try: - # Start all sessions in parallel - print('Starting 10 browser sessions in parallel...') - await asyncio.gather(*[session.start() for session in browser_sessions]) + # Start all sessions sequentially to avoid playwright_global_object semaphore contention + # The playwright global object semaphore only allows 1 concurrent initialization + print('Starting 10 browser sessions sequentially...') + for i, session in enumerate(browser_sessions): + print(f'Starting session {i+1}/10...') + await session.start() # Navigate all sessions to the long page in parallel print('Navigating all sessions to the long test page...') From 7b5ea73b4d5ae96d3e764a48f2d123c35e4295d2 Mon Sep 17 00:00:00 2001 From: Alezander9 Date: Sat, 5 Jul 2025 20:48:37 -0700 Subject: [PATCH 2/3] fix ruff errors --- examples/features/multiple_agents_same_browser.py | 2 +- tests/ci/test_browser_session_screenshots.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/features/multiple_agents_same_browser.py b/examples/features/multiple_agents_same_browser.py index db59f0b7d..81c676fd3 120000 --- a/examples/features/multiple_agents_same_browser.py +++ b/examples/features/multiple_agents_same_browser.py @@ -1 +1 @@ -../browser/multiple_agents_same_browser.py \ No newline at end of file +../browser/multiple_agents_same_browser.py diff --git a/tests/ci/test_browser_session_screenshots.py b/tests/ci/test_browser_session_screenshots.py index 2ba32f10d..a3d04323e 100644 --- a/tests/ci/test_browser_session_screenshots.py +++ b/tests/ci/test_browser_session_screenshots.py @@ -188,7 +188,7 @@ class TestHeadlessScreenshots: # The playwright global object semaphore only allows 1 concurrent initialization print('Starting 10 browser sessions sequentially...') for i, session in enumerate(browser_sessions): - print(f'Starting session {i+1}/10...') + print(f'Starting session {i + 1}/10...') await session.start() # Navigate all sessions to the long page in parallel From faf06f8edb8b28af18217998bb0cb64d0aa9cfbc Mon Sep 17 00:00:00 2001 From: Alezander9 Date: Sat, 5 Jul 2025 20:55:12 -0700 Subject: [PATCH 3/3] remove broken example file --- examples/features/multiple_agents_same_browser.py | 1 - 1 file changed, 1 deletion(-) delete mode 120000 examples/features/multiple_agents_same_browser.py diff --git a/examples/features/multiple_agents_same_browser.py b/examples/features/multiple_agents_same_browser.py deleted file mode 120000 index 81c676fd3..000000000 --- a/examples/features/multiple_agents_same_browser.py +++ /dev/null @@ -1 +0,0 @@ -../browser/multiple_agents_same_browser.py