From 9b3dd67dade823b1ebdca2f887bbd8f5c4264f84 Mon Sep 17 00:00:00 2001 From: Nick Sweeting Date: Fri, 6 Jun 2025 01:23:47 -0700 Subject: [PATCH] stop playwright during browser teardown --- browser_use/browser/session.py | 12 ++++++------ tests/ci/test_browser_session_downloads.py | 4 ---- tests/ci/test_browser_session_tab_management.py | 2 +- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/browser_use/browser/session.py b/browser_use/browser/session.py index 1b209cca6..372e5eb02 100644 --- a/browser_use/browser/session.py +++ b/browser_use/browser/session.py @@ -420,12 +420,12 @@ class BrowserSession(BaseModel): ) # Close playwright if we own it - # if self.playwright: - # try: - # await self.playwright.stop() - # self.playwright = None - # except Exception as e: - # self.logger.debug(f'Error stopping playwright: {type(e).__name__}: {e}') + if self.playwright: + try: + await self.playwright.stop() + self.playwright = None + except Exception as e: + self.logger.debug(f'Error stopping playwright: {type(e).__name__}: {e}') self._reset_connection_state() diff --git a/tests/ci/test_browser_session_downloads.py b/tests/ci/test_browser_session_downloads.py index 09adde99f..efacaf6d6 100644 --- a/tests/ci/test_browser_session_downloads.py +++ b/tests/ci/test_browser_session_downloads.py @@ -161,7 +161,3 @@ async def test_actual_download_detection(test_server, tmp_path): assert duration < 2.0, f'Download detection took {duration:.2f}s, expected <2s' await browser_session.close() - - -if __name__ == '__main__': - pytest.main([__file__, '-v', '-s']) diff --git a/tests/ci/test_browser_session_tab_management.py b/tests/ci/test_browser_session_tab_management.py index dd4c34192..0549ccad0 100644 --- a/tests/ci/test_browser_session_tab_management.py +++ b/tests/ci/test_browser_session_tab_management.py @@ -453,4 +453,4 @@ class TestTabManagement: assert browser_session.browser_context != original_context assert browser_session.initialized is True - await browser_session.stop() + await browser_session.kill()