Files
browser-use/tests/test_service.py
Nick Sweeting d781a3faab fix lint errors
2025-04-28 04:06:19 +08:00

345 lines
12 KiB
Python

from unittest.mock import AsyncMock, MagicMock, Mock, patch
import pytest
from langchain_core.language_models.chat_models import BaseChatModel
from langchain_core.messages import HumanMessage
from pydantic import BaseModel
from browser_use.agent.service import Agent
from browser_use.agent.views import ActionResult
from browser_use.browser.browser import Browser
from browser_use.browser.context import BrowserContext
from browser_use.browser.views import BrowserState
from browser_use.controller.registry.service import Registry
from browser_use.controller.registry.views import ActionModel
from browser_use.controller.service import Controller
# run with python -m pytest tests/test_service.py
# run test with:
# python -m pytest tests/test_service.py
class TestAgent:
@pytest.fixture
def mock_controller(self):
controller = Mock(spec=Controller)
registry = Mock(spec=Registry)
registry.registry = MagicMock()
registry.registry.actions = {'test_action': MagicMock(param_model=MagicMock())} # type: ignore
controller.registry = registry
return controller
@pytest.fixture
def mock_llm(self):
return Mock(spec=BaseChatModel)
@pytest.fixture
def mock_browser(self):
return Mock(spec=Browser)
@pytest.fixture
def mock_browser_context(self):
return Mock(spec=BrowserContext)
def test_convert_initial_actions(self, mock_controller, mock_llm, mock_browser, mock_browser_context): # type: ignore
"""
Test that the _convert_initial_actions method correctly converts
dictionary-based actions to ActionModel instances.
This test ensures that:
1. The method processes the initial actions correctly.
2. The correct param_model is called with the right parameters.
3. The ActionModel is created with the validated parameters.
4. The method returns a list of ActionModel instances.
"""
# Arrange
agent = Agent(
task='Test task', llm=mock_llm, controller=mock_controller, browser=mock_browser, browser_context=mock_browser_context
)
initial_actions = [{'test_action': {'param1': 'value1', 'param2': 'value2'}}]
# Mock the ActionModel
mock_action_model = MagicMock(spec=ActionModel)
mock_action_model_instance = MagicMock()
mock_action_model.return_value = mock_action_model_instance
agent.ActionModel = mock_action_model # type: ignore
# Act
result = agent._convert_initial_actions(initial_actions)
# Assert
assert len(result) == 1
mock_controller.registry.registry.actions['test_action'].param_model.assert_called_once_with( # type: ignore
param1='value1', param2='value2'
)
mock_action_model.assert_called_once()
assert isinstance(result[0], MagicMock)
assert result[0] == mock_action_model_instance
# Check that the ActionModel was called with the correct parameters
call_args = mock_action_model.call_args[1]
assert 'test_action' in call_args
assert call_args['test_action'] == mock_controller.registry.registry.actions['test_action'].param_model.return_value # type: ignore
@pytest.mark.asyncio
async def test_step_error_handling(self):
"""
Test the error handling in the step method of the Agent class.
This test simulates a failure in the get_next_action method and
checks if the error is properly handled and recorded.
"""
# Mock the LLM
mock_llm = MagicMock(spec=BaseChatModel)
# Mock the MessageManager
with patch('browser_use.agent.service.MessageManager') as mock_message_manager:
# Create an Agent instance with mocked dependencies
agent = Agent(task='Test task', llm=mock_llm)
# Mock the get_next_action method to raise an exception
agent.get_next_action = AsyncMock(side_effect=ValueError('Test error'))
# Mock the browser_context
agent.browser_context = AsyncMock()
agent.browser_context.get_state = AsyncMock(
return_value=BrowserState(
url='https://example.com',
title='Example',
element_tree=MagicMock(), # Mocked element tree
tabs=[],
selector_map={},
screenshot='',
)
)
# Mock the controller
agent.controller = AsyncMock()
# Call the step method
await agent.step()
# Assert that the error was handled and recorded
assert agent.consecutive_failures == 1
assert len(agent._last_result) == 1
assert isinstance(agent._last_result[0], ActionResult)
assert 'Test error' in agent._last_result[0].error
assert agent._last_result[0].include_in_memory is True
class TestRegistry:
@pytest.fixture
def registry_with_excludes(self):
return Registry(exclude_actions=['excluded_action'])
def test_action_decorator_with_excluded_action(self, registry_with_excludes):
"""
Test that the action decorator does not register an action
if it's in the exclude_actions list.
"""
# Define a function to be decorated
def excluded_action():
pass
# Apply the action decorator
decorated_func = registry_with_excludes.action(description='This should be excluded')(excluded_action)
# Assert that the decorated function is the same as the original
assert decorated_func == excluded_action
# Assert that the action was not added to the registry
assert 'excluded_action' not in registry_with_excludes.registry.actions
# Define another function that should be included
def included_action():
pass
# Apply the action decorator to an included action
registry_with_excludes.action(description='This should be included')(included_action)
# Assert that the included action was added to the registry
assert 'included_action' in registry_with_excludes.registry.actions
@pytest.mark.asyncio
async def test_execute_action_with_and_without_browser_context(self):
"""
Test that the execute_action method correctly handles actions with and without a browser context.
This test ensures that:
1. An action requiring a browser context is executed correctly.
2. An action not requiring a browser context is executed correctly.
3. The browser context is passed to the action function when required.
4. The action function receives the correct parameters.
5. The method raises an error when a browser context is required but not provided.
"""
registry = Registry()
# Define a mock action model
class TestActionModel(BaseModel):
param1: str
# Define mock action functions
async def test_action_with_browser(param1: str, browser):
return f'Action executed with {param1} and browser'
async def test_action_without_browser(param1: str):
return f'Action executed with {param1}'
# Register the actions
registry.registry.actions['test_action_with_browser'] = MagicMock(
function=AsyncMock(side_effect=test_action_with_browser),
param_model=TestActionModel,
description='Test action with browser',
)
registry.registry.actions['test_action_without_browser'] = MagicMock(
function=AsyncMock(side_effect=test_action_without_browser),
param_model=TestActionModel,
description='Test action without browser',
)
# Mock BrowserContext
mock_browser = MagicMock()
# Execute the action with a browser context
result_with_browser = await registry.execute_action(
'test_action_with_browser', {'param1': 'test_value'}, browser=mock_browser
)
assert result_with_browser == 'Action executed with test_value and browser'
# Execute the action without a browser context
result_without_browser = await registry.execute_action('test_action_without_browser', {'param1': 'test_value'})
assert result_without_browser == 'Action executed with test_value'
# Test error when browser is required but not provided
with pytest.raises(RuntimeError, match='Action test_action_with_browser requires browser but none provided'):
await registry.execute_action('test_action_with_browser', {'param1': 'test_value'})
# Verify that the action functions were called with correct parameters
registry.registry.actions['test_action_with_browser'].function.assert_called_once_with(
param1='test_value', browser=mock_browser
)
registry.registry.actions['test_action_without_browser'].function.assert_called_once_with(param1='test_value')
class TestAgentRetry:
@pytest.fixture
def mock_llm(self):
return AsyncMock()
@pytest.fixture
def mock_controller(self):
controller = Mock()
controller.registry = Mock()
controller.registry.registry = Mock()
controller.registry.registry.actions = {}
return controller
@pytest.fixture
def mock_browser_context(self):
browser_context = Mock()
browser_context.get_state = AsyncMock(
return_value=BrowserState(
url='https://parabank.parasoft.com/parabank/index.htm',
title='ParaBank',
element_tree=MagicMock(),
tabs=[],
selector_map={},
screenshot='',
)
)
return browser_context
@pytest.fixture
def mock_action_model(self):
action_model = Mock(spec=ActionModel)
return action_model
@pytest.mark.asyncio
async def test_step_empty_action_retry(self, mock_llm, mock_controller, mock_browser_context, mock_action_model):
"""
Test that the step method retries and handles empty actions correctly.
"""
# Arrange
agent = Agent(
task='Test task',
llm=mock_llm,
controller=mock_controller,
browser=Mock(),
browser_context=mock_browser_context,
)
agent.ActionModel = mock_action_model # Inject the mock ActionModel
# Mock get_next_action to return empty action the first time, then a valid action
empty_model_output = MagicMock()
empty_model_output.action = [] # Empty action
valid_model_output = MagicMock()
valid_action = MagicMock()
valid_model_output.action = [valid_action]
mock_llm.return_value.invoke.side_effect = [empty_model_output, valid_model_output]
agent.get_next_action = mock_llm.return_value.invoke
# Act
await agent.step()
# Assert
# Check that get_next_action was called twice (initial call + retry)
assert agent.get_next_action.call_count == 2
# Check that the LLM was called twice
assert mock_llm.return_value.invoke.call_count == 2
# Check that the second call to get_next_action included the clarification message
_, retry_messages = mock_llm.return_value.invoke.call_args_list[1]
assert len(retry_messages[0]) == 2 # input_messages + clarification message
assert isinstance(retry_messages[0][1], HumanMessage)
assert 'You forgot to return an action' in retry_messages[0][1].content
# Check that _last_result contains the valid action
assert len(agent._last_result) == 1
assert agent._last_result[0].action == valid_action
@pytest.mark.asyncio
async def test_step_empty_action_retry_and_fail(self, mock_llm, mock_controller, mock_browser_context, mock_action_model):
"""
Test that the step method handles the case where get_next_action returns
empty actions twice, and inserts a safe noop action.
"""
# Arrange
agent = Agent(
task='Test task',
llm=mock_llm,
controller=mock_controller,
browser=Mock(),
browser_context=mock_browser_context,
)
agent.ActionModel = mock_action_model # Inject the mock ActionModel
# Mock get_next_action to return empty action both times
empty_model_output = MagicMock()
empty_model_output.action = [] # Empty action
mock_llm.return_value.invoke.return_value = empty_model_output
agent.get_next_action = mock_llm.return_value.invoke
# Mock the ActionModel instance creation
mock_action_instance = MagicMock()
mock_action_model.return_value = mock_action_instance
# Act
await agent.step()
# Assert
# Check that get_next_action was called twice
assert agent.get_next_action.call_count == 2
# Check that the LLM was called twice
assert mock_llm.return_value.invoke.call_count == 2
# Check that ActionModel was instantiated with the noop action
mock_action_model.assert_called_once()
call_args = mock_action_model.call_args[1]
assert 'done' in call_args
assert call_args['done'] == {'success': False, 'text': 'No action returned, safe exit.'}
# Check that _last_result contains the noop action
assert len(agent._last_result) == 1
assert agent._last_result[0].action == mock_action_instance