claude-mem/ANTI-PATTERN-TODO.md at main

Alex Newman a0dd516cd5 fix: resolve all 301 error handling anti-patterns across codebase

Systematic cleanup of every error handling anti-pattern detected by the
automated scanner. 289 issues fixed via code changes, 12 approved with
specific technical justifications.

Changes across 90 files:
- GENERIC_CATCH (141): Added instanceof Error type discrimination
- LARGE_TRY_BLOCK (82): Extracted helper methods to narrow try scope to ≤10 lines
- NO_LOGGING_IN_CATCH (65): Added logger/console calls for error visibility
- CATCH_AND_CONTINUE_CRITICAL_PATH (10): Added throw/return or approved overrides
- ERROR_STRING_MATCHING (2): Approved with rationale (no typed error classes)
- ERROR_MESSAGE_GUESSING (1): Replaced chained .includes() with documented pattern array
- PROMISE_CATCH_NO_LOGGING (1): Added logging to .catch() handler

Also fixes a detector bug where nested try/catch inside a catch block
corrupted brace-depth tracking, causing false positives.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

13 KiB Raw Permalink Blame History

Anti-Pattern Fix Checklist

src/services/worker-service.ts (14 issues)

src/services/sqlite/SessionStore.ts (7 issues)

src/services/worker/SDKAgent.ts (1 issue)

src/services/worker/GeminiAgent.ts (1 issue)

src/services/worker/OpenRouterAgent.ts (1 issue)

src/services/infrastructure/ProcessManager.ts (20 issues)

src/services/infrastructure/HealthMonitor.ts (3 issues)

src/services/infrastructure/WorktreeAdoption.ts (3 issues)

src/services/worker/SessionManager.ts (5 issues)

src/services/worker/ProcessRegistry.ts (2 issues)

src/services/worker/SearchManager.ts (8 issues)

src/services/worker/BranchManager.ts (5 issues)

src/services/worker/SettingsManager.ts (1 issue)

src/services/worker/PaginationHelper.ts (1 issue)

src/services/worker/knowledge/KnowledgeAgent.ts (4 issues)

src/services/worker/knowledge/CorpusStore.ts (2 issues)

src/services/worker/knowledge/CorpusBuilder.ts (1 issue)

src/services/worker/http/BaseRouteHandler.ts (1 issue)

src/services/worker/http/routes/SearchRoutes.ts (2 issues)

src/services/worker/http/routes/SettingsRoutes.ts (1 issue)

src/services/worker/http/routes/SessionRoutes.ts (5 issues)

src/services/worker/http/routes/CorpusRoutes.ts (1 issue)

src/services/worker/http/routes/ViewerRoutes.ts (1 issue)

src/services/worker/search/strategies/ChromaSearchStrategy.ts (2 issues)

src/services/worker/search/strategies/HybridSearchStrategy.ts (6 issues)

src/services/worker/search/strategies/SQLiteSearchStrategy.ts (2 issues)

src/services/queue/SessionQueueProcessor.ts (2 issues)

src/services/sync/ChromaMcpManager.ts (6 issues)

src/services/sync/ChromaSync.ts (5 issues)

src/services/context/ContextBuilder.ts (1 issue)

src/services/context/ObservationCompiler.ts (2 issues)

src/services/server/Server.ts (3 issues)

src/services/worker-spawner.ts (1 issue)

src/services/smart-file-read/search.ts (2 issues)

src/services/smart-file-read/parser.ts (5 issues)

src/services/sqlite/migrations/runner.ts (4 issues)

src/services/sqlite/migrations.ts (1 issue)

src/services/sqlite/observations/files.ts (1 issue)

src/services/sqlite/timeline/queries.ts (2 issues)

src/services/sqlite/SessionSearch.ts (5 issues)

src/services/transcripts/watcher.ts (4 issues)

src/services/transcripts/processor.ts (3 issues)

src/services/transcripts/field-utils.ts (1 issue)

src/services/integrations/CursorHooksInstaller.ts (11 issues)

src/services/integrations/GeminiCliHooksInstaller.ts (6 issues)

src/services/integrations/OpenCodeInstaller.ts (3 issues)

src/services/integrations/OpenClawInstaller.ts (2 issues)

src/services/integrations/WindsurfHooksInstaller.ts (13 issues)

src/services/integrations/McpIntegrations.ts (4 issues)

src/services/integrations/CodexCliInstaller.ts (9 issues)

src/services/domain/ModeManager.ts (3 issues)

src/supervisor/process-registry.ts (5 issues)

src/supervisor/shutdown.ts (6 issues)

src/supervisor/index.ts (2 issues)

src/cli/hook-command.ts (1 issue)

src/cli/stdin-reader.ts (4 issues)

src/cli/claude-md-commands.ts (12 issues)

src/cli/handlers/session-complete.ts (2 issues)

src/cli/handlers/user-message.ts (1 issue)

src/cli/handlers/context.ts (1 issue)

src/cli/handlers/file-context.ts (3 issues)

src/cli/handlers/summarize.ts (1 issue)

src/cli/handlers/session-init.ts (1 issue)

src/cli/handlers/file-edit.ts (1 issue)

src/cli/handlers/observation.ts (1 issue)

src/ui/viewer/hooks/useStats.ts (1 issue)

src/ui/viewer/hooks/useTheme.ts (2 issues)

src/ui/viewer/hooks/useContextPreview.ts (3 issues)

src/bin/import-xml-observations.ts (7 issues)

src/utils/project-filter.ts (1 issue)

src/utils/worktree.ts (2 issues)

src/utils/claude-md-utils.ts (2 issues)

src/utils/logger.ts (5 issues)

src/utils/json-utils.ts (1 issue)

src/utils/agents-md-utils.ts (1 issue)

src/shared/timeline-formatting.ts (1 issue)

src/shared/plugin-state.ts (1 issue)

src/shared/worker-utils.ts (2 issues)

13 KiB

Raw Permalink Blame History