Alex Newman
a0dd516cd5
fix: resolve all 301 error handling anti-patterns across codebase
Systematic cleanup of every error handling anti-pattern detected by the
automated scanner. 289 issues fixed via code changes, 12 approved with
specific technical justifications.
Changes across 90 files:
- GENERIC_CATCH (141): Added instanceof Error type discrimination
- LARGE_TRY_BLOCK (82): Extracted helper methods to narrow try scope to ≤10 lines
- NO_LOGGING_IN_CATCH (65): Added logger/console calls for error visibility
- CATCH_AND_CONTINUE_CRITICAL_PATH (10): Added throw/return or approved overrides
- ERROR_STRING_MATCHING (2): Approved with rationale (no typed error classes)
- ERROR_MESSAGE_GUESSING (1): Replaced chained .includes() with documented pattern array
- PROMISE_CATCH_NO_LOGGING (1): Added logging to .catch() handler
Also fixes a detector bug where nested try/catch inside a catch block
corrupted brace-depth tracking, causing false positives.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-19 19:57:00 -07:00
..
2026-04-19 19:57:00 -07:00
2026-02-16 00:26:51 -05:00
2025-10-18 23:34:53 -04:00
2026-02-16 00:26:44 -05:00
2026-02-04 19:49:15 -05:00
2025-12-16 17:57:40 -05:00
2026-04-07 18:08:36 -07:00
2025-11-14 15:04:29 -05:00
2025-12-11 14:59:44 -05:00
2025-12-25 15:36:46 -05:00
2026-04-04 15:14:31 -07:00
2026-01-03 21:22:27 -05:00
2026-01-01 23:38:22 -05:00
2026-04-16 17:21:49 -07:00
2025-11-13 18:22:44 -05:00
2025-12-20 17:39:58 -05:00
2025-11-13 18:22:44 -05:00
2026-04-08 17:30:20 -07:00
2025-11-17 14:04:47 -05:00
2026-01-04 00:57:48 -05:00
2025-12-22 20:14:18 -05:00
2025-11-13 18:22:44 -05:00
2025-12-09 15:09:44 -05:00
2025-12-29 23:30:04 -05:00
2025-12-29 23:30:04 -05:00
2025-11-13 18:22:44 -05:00
2026-04-17 20:21:51 -07:00
2025-12-16 17:57:40 -05:00
2025-12-29 23:30:04 -05:00
2025-10-19 01:45:51 -04:00
2026-04-03 10:07:11 +08:00
2026-02-23 17:28:51 -05:00
2026-02-25 21:00:26 -05:00
2026-04-02 20:15:26 +08:00
2025-11-03 14:25:35 -05:00
2025-11-13 18:22:44 -05:00
2025-11-13 18:22:44 -05:00
2025-12-29 23:30:04 -05:00
2025-12-29 23:30:04 -05:00
2026-02-23 19:39:06 -05:00