mirror of
https://github.com/thedotmack/claude-mem
synced 2026-04-26 01:25:10 +02:00
* refactor(worker): remove dead code from worker-service.ts Remove ~216 lines of unreachable code: - Delete `runInteractiveSetup` function (defined but never called) - Remove unused imports: fs namespace, spawn, homedir, readline, existsSync/writeFileSync/readFileSync/mkdirSync - Clean up CursorHooksInstaller imports (keep only used exports) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(worker): only enable SDK fallback when Claude is configured Add isConfigured() method to SDKAgent that checks for ANTHROPIC_API_KEY or claude CLI availability. Worker now only sets SDK agent as fallback for third-party providers when credentials exist, preventing cascading failures for users who intentionally use Gemini/OpenRouter without Claude. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(worker): remove misleading re-export indirection Remove unnecessary re-export of updateCursorContextForProject from worker-service.ts. ResponseProcessor now imports directly from CursorHooksInstaller.ts where the function is defined. This eliminates misleading indirection that suggested a circular dependency existed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use build-time injected version instead of hardcoded strings Replace hardcoded '1.0.0' version strings with __DEFAULT_PACKAGE_VERSION__ constant that esbuild replaces at build time. This ensures MCP server and client versions stay synchronized with package.json. - worker-service.ts: MCP client version now uses packageVersion - ChromaSync.ts: MCP client version now uses packageVersion - mcp-server.ts: MCP server version now uses packageVersion - Added clarifying comments for empty MCP capabilities objects Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: Implement cleanup and validation plans for worker-service.ts - Added a comprehensive cleanup plan addressing 23 identified issues in worker-service.ts, focusing on safe deletions, low-risk simplifications, and medium-risk improvements. - Created an execution plan for validating intentional patterns in worker-service.ts, detailing necessary actions and priorities. - Generated a report on unjustified logic in worker-service.ts, categorizing issues by severity and providing recommendations for immediate and short-term actions. - Introduced documentation for recent activity in the mem-search plugin, enhancing traceability and context for changes. * fix(sdk): remove dangerous ANTHROPIC_API_KEY check from isConfigured Claude Code uses CLI authentication, not direct API calls. Checking for ANTHROPIC_API_KEY could accidentally use a user's API key (from other projects) which costs 20x more than Claude Code's pricing. Now only checks for claude CLI availability. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(worker): remove fallback agent concept entirely Users who choose Gemini/OpenRouter want those providers, not secret fallback behavior. Removed setFallbackAgent calls and the unused isConfigured() method. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
132 lines
5.3 KiB
TypeScript
132 lines
5.3 KiB
TypeScript
import { describe, it, expect } from 'bun:test';
|
|
import { readFileSync, existsSync } from 'fs';
|
|
import path from 'path';
|
|
import { fileURLToPath } from 'url';
|
|
|
|
const __dirname = path.dirname(fileURLToPath(import.meta.url));
|
|
const projectRoot = path.resolve(__dirname, '../..');
|
|
|
|
/**
|
|
* Test suite to ensure version consistency across all package.json files
|
|
* and built artifacts.
|
|
*
|
|
* This prevents the infinite restart loop issue where:
|
|
* - Plugin reads version from plugin/package.json
|
|
* - Worker returns built-in version from bundled code
|
|
* - Mismatch triggers restart on every hook call
|
|
*/
|
|
describe('Version Consistency', () => {
|
|
let rootVersion: string;
|
|
|
|
it('should read version from root package.json', () => {
|
|
const packageJsonPath = path.join(projectRoot, 'package.json');
|
|
expect(existsSync(packageJsonPath)).toBe(true);
|
|
|
|
const packageJson = JSON.parse(readFileSync(packageJsonPath, 'utf-8'));
|
|
expect(packageJson.version).toBeDefined();
|
|
expect(packageJson.version).toMatch(/^\d+\.\d+\.\d+$/);
|
|
|
|
rootVersion = packageJson.version;
|
|
});
|
|
|
|
it('should have matching version in plugin/package.json', () => {
|
|
const pluginPackageJsonPath = path.join(projectRoot, 'plugin/package.json');
|
|
expect(existsSync(pluginPackageJsonPath)).toBe(true);
|
|
|
|
const pluginPackageJson = JSON.parse(readFileSync(pluginPackageJsonPath, 'utf-8'));
|
|
expect(pluginPackageJson.version).toBe(rootVersion);
|
|
});
|
|
|
|
it('should have matching version in plugin/.claude-plugin/plugin.json', () => {
|
|
const pluginJsonPath = path.join(projectRoot, 'plugin/.claude-plugin/plugin.json');
|
|
expect(existsSync(pluginJsonPath)).toBe(true);
|
|
|
|
const pluginJson = JSON.parse(readFileSync(pluginJsonPath, 'utf-8'));
|
|
expect(pluginJson.version).toBe(rootVersion);
|
|
});
|
|
|
|
it('should have matching version in .claude-plugin/marketplace.json', () => {
|
|
const marketplaceJsonPath = path.join(projectRoot, '.claude-plugin/marketplace.json');
|
|
expect(existsSync(marketplaceJsonPath)).toBe(true);
|
|
|
|
const marketplaceJson = JSON.parse(readFileSync(marketplaceJsonPath, 'utf-8'));
|
|
expect(marketplaceJson.plugins).toBeDefined();
|
|
expect(marketplaceJson.plugins.length).toBeGreaterThan(0);
|
|
|
|
const claudeMemPlugin = marketplaceJson.plugins.find((p: any) => p.name === 'claude-mem');
|
|
expect(claudeMemPlugin).toBeDefined();
|
|
expect(claudeMemPlugin.version).toBe(rootVersion);
|
|
});
|
|
|
|
it('should have version injected into built worker-service.cjs', () => {
|
|
const workerServicePath = path.join(projectRoot, 'plugin/scripts/worker-service.cjs');
|
|
|
|
// Skip if file doesn't exist (e.g., before first build)
|
|
if (!existsSync(workerServicePath)) {
|
|
console.log('⚠️ worker-service.cjs not found - run npm run build first');
|
|
return;
|
|
}
|
|
|
|
const workerServiceContent = readFileSync(workerServicePath, 'utf-8');
|
|
|
|
// The build script injects version via esbuild define:
|
|
// define: { '__DEFAULT_PACKAGE_VERSION__': `"${version}"` }
|
|
// This becomes: const BUILT_IN_VERSION = "9.0.0" (or minified: Bre="9.0.0")
|
|
|
|
// Check for the version string in the minified code
|
|
const versionPattern = new RegExp(`"${rootVersion.replace(/\./g, '\\.')}"`, 'g');
|
|
const matches = workerServiceContent.match(versionPattern);
|
|
|
|
expect(matches).toBeTruthy();
|
|
expect(matches!.length).toBeGreaterThan(0);
|
|
});
|
|
|
|
it('should have built mcp-server.cjs', () => {
|
|
const mcpServerPath = path.join(projectRoot, 'plugin/scripts/mcp-server.cjs');
|
|
|
|
// Skip if file doesn't exist (e.g., before first build)
|
|
if (!existsSync(mcpServerPath)) {
|
|
console.log('⚠️ mcp-server.cjs not found - run npm run build first');
|
|
return;
|
|
}
|
|
|
|
// mcp-server.cjs doesn't use __DEFAULT_PACKAGE_VERSION__ - it's a search server
|
|
// that doesn't need to expose version info. Just verify it exists and is built.
|
|
const mcpServerContent = readFileSync(mcpServerPath, 'utf-8');
|
|
expect(mcpServerContent.length).toBeGreaterThan(0);
|
|
});
|
|
|
|
it('should validate version format is semver compliant', () => {
|
|
// Ensure version follows semantic versioning: MAJOR.MINOR.PATCH
|
|
expect(rootVersion).toMatch(/^\d+\.\d+\.\d+$/);
|
|
|
|
const [major, minor, patch] = rootVersion.split('.').map(Number);
|
|
expect(major).toBeGreaterThanOrEqual(0);
|
|
expect(minor).toBeGreaterThanOrEqual(0);
|
|
expect(patch).toBeGreaterThanOrEqual(0);
|
|
});
|
|
});
|
|
|
|
/**
|
|
* Additional test to ensure build script properly reads and injects version
|
|
*/
|
|
describe('Build Script Version Handling', () => {
|
|
it('should read version from package.json in build-hooks.js', () => {
|
|
const buildScriptPath = path.join(projectRoot, 'scripts/build-hooks.js');
|
|
expect(existsSync(buildScriptPath)).toBe(true);
|
|
|
|
const buildScriptContent = readFileSync(buildScriptPath, 'utf-8');
|
|
|
|
// Verify build script reads from package.json
|
|
expect(buildScriptContent).toContain("readFileSync('package.json'");
|
|
expect(buildScriptContent).toContain('packageJson.version');
|
|
|
|
// Verify it generates plugin/package.json with the version
|
|
expect(buildScriptContent).toContain('version: version');
|
|
|
|
// Verify it injects version into esbuild define
|
|
expect(buildScriptContent).toContain('__DEFAULT_PACKAGE_VERSION__');
|
|
expect(buildScriptContent).toContain('`"${version}"`');
|
|
});
|
|
});
|