From 7b363d4624ef2e9b83705b1cd2b37008fe96152f Mon Sep 17 00:00:00 2001
From: lebaudantoine <lebaud.antoine131@gmail.com>
Date: Wed, 21 May 2025 16:19:34 +0200
Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=EF=B8=8F(frontend)=20prevent=20authen?=
 =?UTF-8?q?tication=20retry=20on=20401=20responses?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Stop retry attempts when receiving 401 Unauthorized from /me endpoint since
this clearly indicates authentication status. The original purpose of the /me
call is simply to determine if user is authenticated, and a 401 provides
sufficient information.

Prevents unnecessary network requests caused by React Query's automatic retry
behavior when re-raising exceptions, which was hiding the 401 status. Improves
performance and reduces server load during authentication failures.
---
 src/frontend/apps/impress/src/core/AppProvider.tsx       | 4 +++-
 .../apps/impress/src/features/auth/api/useAuthQuery.tsx  | 9 +++++++++
 .../features/language/hooks/useLanguageSynchronizer.ts   | 2 +-
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/src/frontend/apps/impress/src/core/AppProvider.tsx b/src/frontend/apps/impress/src/core/AppProvider.tsx
index 03ce5097d..9f18e1142 100644
--- a/src/frontend/apps/impress/src/core/AppProvider.tsx
+++ b/src/frontend/apps/impress/src/core/AppProvider.tsx
@@ -9,6 +9,8 @@ import { useResponsiveStore } from '@/stores/';
 
 import { ConfigProvider } from './config/';
 
+export const DEFAULT_QUERY_RETRY = 1;
+
 /**
  * QueryClient:
  *  - defaultOptions:
@@ -19,7 +21,7 @@ import { ConfigProvider } from './config/';
 const defaultOptions = {
   queries: {
     staleTime: 1000 * 60 * 3,
-    retry: 1,
+    retry: DEFAULT_QUERY_RETRY,
   },
 };
 const queryClient = new QueryClient({
diff --git a/src/frontend/apps/impress/src/features/auth/api/useAuthQuery.tsx b/src/frontend/apps/impress/src/features/auth/api/useAuthQuery.tsx
index 026beec9f..4c15e39ce 100644
--- a/src/frontend/apps/impress/src/features/auth/api/useAuthQuery.tsx
+++ b/src/frontend/apps/impress/src/features/auth/api/useAuthQuery.tsx
@@ -1,6 +1,7 @@
 import { UseQueryOptions, useQuery } from '@tanstack/react-query';
 
 import { APIError, errorCauses, fetchAPI } from '@/api';
+import { DEFAULT_QUERY_RETRY } from '@/core';
 
 import { User } from './types';
 
@@ -16,6 +17,7 @@ import { User } from './types';
  */
 export const getMe = async (): Promise<User> => {
   const response = await fetchAPI(`users/me/`);
+
   if (!response.ok) {
     throw new APIError(
       `Couldn't fetch user data: ${response.statusText}`,
@@ -34,6 +36,13 @@ export function useAuthQuery(
     queryKey: [KEY_AUTH],
     queryFn: getMe,
     staleTime: 1000 * 60 * 15, // 15 minutes
+    retry: (failureCount, error) => {
+      // we assume that a 401 means the user is not logged in
+      if (error.status == 401) {
+        return false;
+      }
+      return failureCount < DEFAULT_QUERY_RETRY;
+    },
     ...queryConfig,
   });
 }
diff --git a/src/frontend/apps/impress/src/features/language/hooks/useLanguageSynchronizer.ts b/src/frontend/apps/impress/src/features/language/hooks/useLanguageSynchronizer.ts
index e6bb23b99..7ecd2f3ad 100644
--- a/src/frontend/apps/impress/src/features/language/hooks/useLanguageSynchronizer.ts
+++ b/src/frontend/apps/impress/src/features/language/hooks/useLanguageSynchronizer.ts
@@ -2,7 +2,7 @@ import { useCallback, useMemo, useRef } from 'react';
 import { useTranslation } from 'react-i18next';
 
 import { useConfig } from '@/core';
-import { useAuthQuery } from '@/features/auth/api';
+import { useAuthQuery } from '@/features/auth';
 import { useChangeUserLanguage } from '@/features/language/api/useChangeUserLanguage';
 import { getMatchingLocales } from '@/features/language/utils/locale';
 import { availableFrontendLanguages } from '@/i18n/initI18n';