diff --git a/bin/install.js b/bin/install.js index 737e7cd6..991f9325 100755 --- a/bin/install.js +++ b/bin/install.js @@ -1894,6 +1894,14 @@ function convertClaudeToCodexMarkdown(content) { converted = converted.replace(/\$HOME\/\.claude\//g, '$HOME/.codex/'); converted = converted.replace(/~\/\.claude\//g, '~/.codex/'); converted = converted.replace(/\.\/\.claude\//g, './.codex/'); + // Bare/project-relative .claude/... references (#2639). Covers strings like + // "check `.claude/skills/`" where there is no ~/, $HOME/, or ./ anchor. + // Negative lookbehind prevents double-replacing already-anchored forms and + // avoids matching inside URLs or other slash-prefixed paths. + converted = converted.replace(/(? { + let tmpDir; + let agentsSrc; + let targetDir; + + beforeEach(() => { + tmpDir = makeTempDir(); + agentsSrc = path.join(tmpDir, 'agents'); + targetDir = path.join(tmpDir, 'codex'); + fs.mkdirSync(agentsSrc, { recursive: true }); + fs.mkdirSync(targetDir, { recursive: true }); + }); + + afterEach(() => { + fs.rmSync(tmpDir, { recursive: true, force: true }); + }); + + test('strips CLAUDE.md, .claude/skills/, .claude/commands/, .claude/agents/, and .claudeignore from emitted TOML', () => { + writeAgentFixture(agentsSrc, 'gsd-code-reviewer', [ + '**Project instructions:** Read `./CLAUDE.md` if it exists.', + '', + '**CLAUDE.md enforcement:** If `./CLAUDE.md` exists, treat it as hard constraints.', + '', + '**Project skills:** Check `.claude/skills/` or `.agents/skills/` directory.', + '', + 'Also check `.claude/commands/` and `.claude/agents/` for definitions.', + '', + 'DO respect .gitignore and .claudeignore. Do not review ignored files.', + '', + 'Claude will refuse the task if policy violated.', + ].join('\n')); + + installCodexConfig(targetDir, agentsSrc); + + const tomlPath = path.join(targetDir, 'agents', 'gsd-code-reviewer.toml'); + assert.ok(fs.existsSync(tomlPath), 'per-agent TOML written'); + const toml = fs.readFileSync(tomlPath, 'utf8'); + + assert.ok(!toml.includes('CLAUDE.md'), 'no CLAUDE.md references remain in TOML'); + assert.ok(!toml.includes('.claude/skills/'), 'no .claude/skills/ references remain'); + assert.ok(!toml.includes('.claude/commands/'), 'no .claude/commands/ references remain'); + assert.ok(!toml.includes('.claude/agents/'), 'no .claude/agents/ references remain'); + assert.ok(!toml.includes('.claudeignore'), 'no .claudeignore references remain'); + + assert.ok(toml.includes('AGENTS.md'), 'AGENTS.md substituted for CLAUDE.md'); + assert.ok( + toml.includes('.codex/skills/') || toml.includes('.agents/skills/'), + 'skills path neutralized' + ); + + // Standalone "Claude" agent-name references replaced + assert.ok(!/\bClaude\b(?! Code| Opus| Sonnet| Haiku| native| based)/.test(toml), + 'standalone Claude agent-name references replaced'); + }); + + test('preserves Claude product/model names (Claude Code, Claude Opus) in TOML', () => { + writeAgentFixture(agentsSrc, 'gsd-executor', [ + 'This agent runs under Claude Code with the Claude Opus 4 model.', + 'Do not confuse with Claude Sonnet or Claude Haiku.', + ].join('\n')); + + installCodexConfig(targetDir, agentsSrc); + const toml = fs.readFileSync(path.join(targetDir, 'agents', 'gsd-executor.toml'), 'utf8'); + + assert.ok(toml.includes('Claude Code'), 'Claude Code product name preserved'); + assert.ok(toml.includes('Claude Opus'), 'Claude Opus model name preserved'); + }); +});