Files
get-shit-done/tests/gates-taxonomy.test.cjs
Rezolv d3a79917fa feat: Phase 2 caller migration — gsd-sdk query in workflows, agents, commands (#2179)
* feat: Phase 2 caller migration — gsd-sdk query in workflows (#2122)

Cherry-picked orchestration rewrites from feat/sdk-foundation (#2008, 4018fee) onto current main, resolving conflicts to keep upstream worktree guards and post-merge test gate. SDK stub registry omitted (out of Phase 2 scope per #2122).

Refs: #2122 #2008
Made-with: Cursor

* docs: add gsd-sdk query migration blurb

Made-with: Cursor

* docs(workflows): extend Phase 2 gsd-sdk query caller migration

- Swap node gsd-tools.cjs for gsd-sdk query in review, plan-phase, execute-plan,
  ship, extract_learnings, ai-integration-phase, eval-review, next, thread
- Document graphify CJS-only in gsd-planner; dual-path in CLI-TOOLS and ARCHITECTURE
- Update tests: workstreams gsd-sdk path, thread frontmatter.get, workspace init.*,
  CRLF-safe autonomous frontmatter parse
- CHANGELOG: Phase 2 caller migration scope

Made-with: Cursor

* docs(phase2): USER-GUIDE + remaining gsd-sdk query call sites

- USER-GUIDE: dual-path CLI section; state validate/sync use full CJS path
- Commands: debug (config-get+tdd), quick (security note), intel Task prompt
- Agent: gsd-debug-session-manager resolve-model via jq
- Workflows: milestone-summary, forensics, next, complete-milestone/verify-work
  (audit-open CJS notes), discuss-phase, progress, verify-phase, add/insert/remove
  phase, transition, manager, quick workflow; remove-phase commit without --files
- Test: quick-session-management accepts frontmatter.get
- CHANGELOG: Phase 2 follow-up bullet

Made-with: Cursor

* docs(phase2): align gsd-sdk query examples in commands and agents

- init.* query names; frontmatter.get uses positional field name
- state.* handlers use positional args; commit uses positional paths
- CJS-only notes for from-gsd2 and graphify; learnings.query wording
- CHANGELOG: Phase 2 orchestration doc pass

Made-with: Cursor

* docs(phase2): normalize gsd-sdk query commit to positional file paths

- Strip --files from commit examples in workflows, references, commands
- Keep commit-to-subrepo ... --files (separate handler)
- git-planning-commit.md: document positional args
- Tests: new-project commit line, state.record-session, gates CRLF, roadmap.analyze
- CHANGELOG [Unreleased]

Made-with: Cursor

* feat(sdk): gsd-sdk query parity with gsd-tools and PR 2179 registry fixes

- Route query via longest-prefix match and dotted single-token expansion; fall back
  to runGsdToolsQuery (same argv as node gsd-tools.cjs) for full CLI coverage.
- Parse gsd-sdk query permissively so gsd-tools flags (--json, --verify, etc.) are
  not rejected by strict parseArgs.
- resolveGsdToolsPath: honor GSD_TOOLS_PATH; prefer bundled get-shit-done copy
  over project .claude installs; export runGsdToolsQuery from the SDK.
- Fix gsd-tools audit-open (core.output; pass object for --json JSON).
- Register summary-extract as alias of summary.extract; fix audit-fix workflow to
  call audit-uat instead of invalid init.audit-uat (PR review).

Updates QUERY-HANDLERS.md and CHANGELOG [Unreleased].

Made-with: Cursor

* fix(sdk): Phase 2 scope — Trek-e review (#2179, #2122)

- Remove gsd-sdk query passthrough to gsd-tools.cjs; drop GSD_TOOLS_PATH
- Consolidate argv routing in resolveQueryArgv(); update USAGE and QUERY-HANDLERS
- Surface @file: read failures in GSDTools.parseOutput
- execute-plan: defer Task Commit Protocol to gsd-executor
- stale-colon-refs: skip .planning/ and root CLAUDE.md (gitignored overlays)
- CHANGELOG [Unreleased]: maintainer review and routing notes

Made-with: Cursor
2026-04-15 22:46:31 -04:00

125 lines
4.5 KiB
JavaScript

/**
* Validates the gates taxonomy reference document (#1715).
*
* Ensures the reference file exists, defines all 4 canonical gate types,
* includes the gate matrix table, and is cross-referenced from workflows.
*/
const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
const ROOT = path.join(__dirname, '..');
const GATES_REF = path.join(ROOT, 'get-shit-done', 'references', 'gates.md');
describe('gates taxonomy (#1715)', () => {
test('reference file exists', () => {
assert.ok(
fs.existsSync(GATES_REF),
'get-shit-done/references/gates.md must exist'
);
});
test('defines all 4 canonical gate types', () => {
const content = fs.readFileSync(GATES_REF, 'utf-8');
const gateTypes = ['Pre-flight Gate', 'Revision Gate', 'Escalation Gate', 'Abort Gate'];
for (const gate of gateTypes) {
assert.ok(
content.includes(`### ${gate}`),
`gates.md must define "${gate}" as an h3 heading`
);
}
});
test('each gate type has Purpose, Behavior, Recovery, and Examples', () => {
const content = fs.readFileSync(GATES_REF, 'utf-8');
const sections = content.split('### ').slice(1); // split by h3, drop preamble
for (const section of sections) {
const name = section.split('\n')[0].trim();
// Only check gate type sections (not other h3s if any)
if (!name.endsWith('Gate')) continue;
for (const field of ['**Purpose:**', '**Behavior:**', '**Recovery:**', '**Examples:**']) {
assert.ok(
section.includes(field),
`Gate "${name}" must include ${field}`
);
}
}
});
test('contains Gate Matrix table', () => {
const content = fs.readFileSync(GATES_REF, 'utf-8');
assert.ok(
content.includes('## Gate Matrix'),
'gates.md must include a "Gate Matrix" section'
);
// Verify table header row
assert.ok(
content.includes('| Workflow |'),
'Gate Matrix must contain a table with Workflow column'
);
// Verify key workflow rows exist
assert.ok(content.includes('plan-phase'), 'Gate Matrix must reference plan-phase');
assert.ok(content.includes('execute-phase'), 'Gate Matrix must reference execute-phase');
assert.ok(content.includes('verify-work'), 'Gate Matrix must reference verify-work');
assert.ok(content.includes('| next |'), 'Gate Matrix must reference next workflow');
});
test('plan-phase.md references gates.md', () => {
const planPhase = path.join(ROOT, 'get-shit-done', 'workflows', 'plan-phase.md');
const content = fs.readFileSync(planPhase, 'utf-8');
assert.ok(
content.includes('references/gates.md'),
'plan-phase.md must reference gates.md in its required_reading block'
);
});
test('execute-phase.md references gates.md', () => {
const execPhase = path.join(ROOT, 'get-shit-done', 'workflows', 'execute-phase.md');
const content = fs.readFileSync(execPhase, 'utf-8');
assert.ok(
content.includes('references/gates.md'),
'execute-phase.md must reference gates.md in its required_reading block'
);
});
test('gsd-plan-checker.md references gates.md in required_reading block', () => {
const planChecker = path.join(ROOT, 'agents', 'gsd-plan-checker.md');
const content = fs.readFileSync(planChecker, 'utf-8');
const match = content.match(/<required_reading>\r?\n([\s\S]*?)\r?\n<\/required_reading>/);
assert.ok(
match,
'gsd-plan-checker.md must have a <required_reading> block'
);
assert.ok(
match[1].includes('references/gates.md'),
'gsd-plan-checker.md must reference gates.md inside <required_reading>'
);
});
test('gsd-verifier.md references gates.md in required_reading block', () => {
const verifier = path.join(ROOT, 'agents', 'gsd-verifier.md');
const content = fs.readFileSync(verifier, 'utf-8');
const match = content.match(/<required_reading>\r?\n([\s\S]*?)\r?\n<\/required_reading>/);
assert.ok(
match,
'gsd-verifier.md must have a <required_reading> block'
);
assert.ok(
match[1].includes('references/gates.md'),
'gsd-verifier.md must reference gates.md inside <required_reading>'
);
});
test('Revision Gate recovery mentions stall detection', () => {
const content = fs.readFileSync(GATES_REF, 'utf-8');
assert.ok(
content.includes('stall detection'),
'Revision Gate recovery must mention stall detection (early escalation when issues stop decreasing)'
);
});
});