mirror of
https://github.com/glittercowboy/get-shit-done
synced 2026-04-25 17:25:23 +02:00
47badff2ee
AskUserQuestion is a Claude Code-only tool. When running GSD on OpenAI Codex, Gemini CLI, or other non-Claude runtimes, the model renders the tool call as a markdown code block instead of executing it, so the interactive TUI never appears and the session stalls without collecting user input. The workflow.text_mode / --text flag mechanism already handles this in 5 of the 37 affected workflows. This commit adds the same TEXT_MODE fallback instruction to all remaining 32 workflows so that, when text_mode is enabled, every AskUserQuestion call is replaced with a plain-text numbered list that any runtime can handle. Fixes #2012 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
84 lines
3.0 KiB
JavaScript
84 lines
3.0 KiB
JavaScript
/**
|
|
* Regression guard for #2012: AskUserQuestion is Claude Code-only — non-Claude
|
|
* runtimes (OpenAI Codex, Gemini, etc.) render it as a markdown code block
|
|
* instead of triggering the interactive TUI, so the session stalls.
|
|
*
|
|
* Every workflow that calls AskUserQuestion MUST include a TEXT_MODE fallback
|
|
* instruction so that, when `workflow.text_mode` is true (or `--text` is
|
|
* passed), all AskUserQuestion calls are replaced with plain-text numbered
|
|
* lists that any runtime can handle.
|
|
*
|
|
* The canonical fallback phrase is:
|
|
* "TEXT_MODE" (or "text_mode") paired with "plain-text" (or "plain text")
|
|
* near the first AskUserQuestion reference in the file.
|
|
*/
|
|
'use strict';
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const ROOT = path.join(__dirname, '..');
|
|
const WORKFLOWS_DIR = path.join(ROOT, 'get-shit-done', 'workflows');
|
|
|
|
/**
|
|
* Return true if the file content contains a TEXT_MODE / text_mode fallback
|
|
* instruction for AskUserQuestion calls.
|
|
*
|
|
* Acceptable forms (case-insensitive on key terms):
|
|
* - "TEXT_MODE" + "plain-text" or "plain text"
|
|
* - "text_mode" + "plain-text" or "plain text"
|
|
* - "text mode" + "plain-text" or "plain text"
|
|
*/
|
|
function hasTextModeFallback(content) {
|
|
const lower = content.toLowerCase();
|
|
const hasTextMode =
|
|
lower.includes('text_mode') ||
|
|
lower.includes('text mode');
|
|
const hasPlainText =
|
|
lower.includes('plain-text') ||
|
|
lower.includes('plain text') ||
|
|
lower.includes('numbered list');
|
|
return hasTextMode && hasPlainText;
|
|
}
|
|
|
|
describe('AskUserQuestion text-mode fallback (#2012)', () => {
|
|
test('every workflow that uses AskUserQuestion includes a TEXT_MODE plain-text fallback', () => {
|
|
const violations = [];
|
|
|
|
const files = fs.readdirSync(WORKFLOWS_DIR).filter(f => f.endsWith('.md'));
|
|
|
|
for (const fname of files) {
|
|
const fpath = path.join(WORKFLOWS_DIR, fname);
|
|
const content = fs.readFileSync(fpath, 'utf-8');
|
|
|
|
if (!content.includes('AskUserQuestion')) continue;
|
|
|
|
if (!hasTextModeFallback(content)) {
|
|
violations.push(fname);
|
|
}
|
|
}
|
|
|
|
assert.strictEqual(
|
|
violations.length,
|
|
0,
|
|
[
|
|
'AskUserQuestion is Claude Code-only (issue #2012).',
|
|
'Every workflow that uses AskUserQuestion must include a TEXT_MODE fallback',
|
|
'so non-Claude runtimes (OpenAI Codex, Gemini, etc.) can present questions',
|
|
'as plain-text numbered lists instead of stalling on an unexecuted tool call.',
|
|
'',
|
|
'Add this near the argument-parsing section of each workflow:',
|
|
' Set TEXT_MODE=true if --text is present in $ARGUMENTS OR text_mode from',
|
|
' init JSON is true. When TEXT_MODE is active, replace every AskUserQuestion',
|
|
' call with a plain-text numbered list and ask the user to type their choice',
|
|
' number.',
|
|
'',
|
|
'Workflows missing the fallback:',
|
|
...violations.map(v => ' get-shit-done/workflows/' + v),
|
|
].join('\n')
|
|
);
|
|
});
|
|
});
|