Files
get-shit-done/tests/thread-session-management.test.cjs
Rezolv d3a79917fa feat: Phase 2 caller migration — gsd-sdk query in workflows, agents, commands (#2179)
* feat: Phase 2 caller migration — gsd-sdk query in workflows (#2122)

Cherry-picked orchestration rewrites from feat/sdk-foundation (#2008, 4018fee) onto current main, resolving conflicts to keep upstream worktree guards and post-merge test gate. SDK stub registry omitted (out of Phase 2 scope per #2122).

Refs: #2122 #2008
Made-with: Cursor

* docs: add gsd-sdk query migration blurb

Made-with: Cursor

* docs(workflows): extend Phase 2 gsd-sdk query caller migration

- Swap node gsd-tools.cjs for gsd-sdk query in review, plan-phase, execute-plan,
  ship, extract_learnings, ai-integration-phase, eval-review, next, thread
- Document graphify CJS-only in gsd-planner; dual-path in CLI-TOOLS and ARCHITECTURE
- Update tests: workstreams gsd-sdk path, thread frontmatter.get, workspace init.*,
  CRLF-safe autonomous frontmatter parse
- CHANGELOG: Phase 2 caller migration scope

Made-with: Cursor

* docs(phase2): USER-GUIDE + remaining gsd-sdk query call sites

- USER-GUIDE: dual-path CLI section; state validate/sync use full CJS path
- Commands: debug (config-get+tdd), quick (security note), intel Task prompt
- Agent: gsd-debug-session-manager resolve-model via jq
- Workflows: milestone-summary, forensics, next, complete-milestone/verify-work
  (audit-open CJS notes), discuss-phase, progress, verify-phase, add/insert/remove
  phase, transition, manager, quick workflow; remove-phase commit without --files
- Test: quick-session-management accepts frontmatter.get
- CHANGELOG: Phase 2 follow-up bullet

Made-with: Cursor

* docs(phase2): align gsd-sdk query examples in commands and agents

- init.* query names; frontmatter.get uses positional field name
- state.* handlers use positional args; commit uses positional paths
- CJS-only notes for from-gsd2 and graphify; learnings.query wording
- CHANGELOG: Phase 2 orchestration doc pass

Made-with: Cursor

* docs(phase2): normalize gsd-sdk query commit to positional file paths

- Strip --files from commit examples in workflows, references, commands
- Keep commit-to-subrepo ... --files (separate handler)
- git-planning-commit.md: document positional args
- Tests: new-project commit line, state.record-session, gates CRLF, roadmap.analyze
- CHANGELOG [Unreleased]

Made-with: Cursor

* feat(sdk): gsd-sdk query parity with gsd-tools and PR 2179 registry fixes

- Route query via longest-prefix match and dotted single-token expansion; fall back
  to runGsdToolsQuery (same argv as node gsd-tools.cjs) for full CLI coverage.
- Parse gsd-sdk query permissively so gsd-tools flags (--json, --verify, etc.) are
  not rejected by strict parseArgs.
- resolveGsdToolsPath: honor GSD_TOOLS_PATH; prefer bundled get-shit-done copy
  over project .claude installs; export runGsdToolsQuery from the SDK.
- Fix gsd-tools audit-open (core.output; pass object for --json JSON).
- Register summary-extract as alias of summary.extract; fix audit-fix workflow to
  call audit-uat instead of invalid init.audit-uat (PR review).

Updates QUERY-HANDLERS.md and CHANGELOG [Unreleased].

Made-with: Cursor

* fix(sdk): Phase 2 scope — Trek-e review (#2179, #2122)

- Remove gsd-sdk query passthrough to gsd-tools.cjs; drop GSD_TOOLS_PATH
- Consolidate argv routing in resolveQueryArgv(); update USAGE and QUERY-HANDLERS
- Surface @file: read failures in GSDTools.parseOutput
- execute-plan: defer Task Commit Protocol to gsd-executor
- stale-colon-refs: skip .planning/ and root CLAUDE.md (gitignored overlays)
- CHANGELOG [Unreleased]: maintainer review and routing notes

Made-with: Cursor
2026-04-15 22:46:31 -04:00

106 lines
3.1 KiB
JavaScript

'use strict';
const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
describe('thread session management (#2156)', () => {
const threadCmd = fs.readFileSync(
path.join(__dirname, '..', 'commands', 'gsd', 'thread.md'),
'utf8'
);
test('thread command has list subcommand with status filter', () => {
assert.ok(
threadCmd.includes('list --open') || threadCmd.includes('LIST-OPEN'),
'missing list --open filter'
);
});
test('thread command has close subcommand', () => {
assert.ok(
threadCmd.includes('CLOSE') || threadCmd.includes('close <slug>'),
'missing close subcommand'
);
});
test('thread command has status subcommand', () => {
assert.ok(
threadCmd.includes('STATUS') || threadCmd.includes('status <slug>'),
'missing status subcommand'
);
});
test('thread command does not use heredoc', () => {
assert.ok(
!threadCmd.includes("<< 'EOF'") && !threadCmd.includes('<< EOF'),
'thread command still uses heredoc — injection risk'
);
});
test('thread template includes frontmatter status field', () => {
assert.ok(
threadCmd.includes('status: open') || threadCmd.includes('status:'),
'thread template missing frontmatter status field'
);
});
test('thread command has security_notes section', () => {
assert.ok(threadCmd.includes('security_notes'), 'missing security_notes section');
});
test('thread command has slug sanitization', () => {
assert.ok(
threadCmd.includes('sanitiz') || threadCmd.includes('[a-z0-9'),
'missing slug sanitization'
);
});
test('thread command uses Write tool for file creation', () => {
assert.ok(
threadCmd.includes('Write tool'),
'thread create mode should use the Write tool instead of heredoc'
);
});
test('thread command list reads frontmatter status', () => {
assert.ok(
threadCmd.includes('frontmatter get') || threadCmd.includes('frontmatter.get'),
'list mode should read status via frontmatter get / frontmatter.get'
);
});
test('thread command close updates status to resolved', () => {
assert.ok(
threadCmd.includes('resolved'),
'close mode should set status to resolved'
);
});
test('thread command list shows resolved filter option', () => {
assert.ok(
threadCmd.includes('list --resolved') || threadCmd.includes('LIST-RESOLVED'),
'missing list --resolved filter'
);
});
test('thread command rejects slugs with path traversal', () => {
assert.ok(
threadCmd.includes('..') && threadCmd.includes('reject'),
'missing path traversal rejection for slugs'
);
});
test('thread create uses frontmatter with slug title status created updated fields', () => {
assert.ok(
threadCmd.includes('slug:') &&
threadCmd.includes('title:') &&
threadCmd.includes('status:') &&
threadCmd.includes('created:') &&
threadCmd.includes('updated:'),
'thread template missing required frontmatter fields'
);
});
});