mirror of
https://github.com/glittercowboy/get-shit-done
synced 2026-04-25 17:25:23 +02:00
9d55d531a4
- quick.md Step 5.6: commit PLAN.md to base branch before worktree executor spawn when USE_WORKTREES is active, preventing CC #36182 path-resolution drift that caused silent writes to main repo instead of worktree - reapply-patches.md Option A: replace first-add commit heuristic with pristine_hashes SHA-256 matching from backup-meta.json so baseline detection works correctly on multi-cycle repos; first-add fallback kept for older installers without pristine_hashes - CONFIGURATION.md: move security_enforcement/security_asvs_level/security_block_on to workflow.* (matches templates/config.json and workflow readers); rename context_profile → context (matches VALID_CONFIG_KEYS in config.cjs); add planning.sub_repos to schema example - universal-anti-patterns.md + context-budget.md: fix context_window_tokens → context_window (the actual key name in config.cjs) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
103 lines
4.3 KiB
JavaScript
103 lines
4.3 KiB
JavaScript
/**
|
|
* Bug #2432: quick.md PLAN.md timing — worktree executor can't read PLAN.md
|
|
*
|
|
* The orchestrator must commit PLAN.md to the base branch BEFORE spawning the
|
|
* worktree-isolated executor. Without this, the executor's first Read resolves
|
|
* to a main-repo absolute path (not a worktree path), which primes CC's path
|
|
* cache and causes subsequent Edit/Write calls to silently target the main repo
|
|
* instead of the worktree (CC issue #36182 amplifier).
|
|
*
|
|
* Fix: Step 5.6 commits PLAN.md pre-dispatch when USE_WORKTREES is active.
|
|
*/
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const QUICK_MD = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'quick.md');
|
|
|
|
describe('quick.md pre-dispatch PLAN.md commit (#2432)', () => {
|
|
let content;
|
|
|
|
test('quick.md exists', () => {
|
|
assert.ok(fs.existsSync(QUICK_MD), 'get-shit-done/workflows/quick.md must exist');
|
|
content = fs.readFileSync(QUICK_MD, 'utf-8');
|
|
});
|
|
|
|
test('Step 5.6 exists between Step 5.5 and Step 6', () => {
|
|
const step55 = content.indexOf('Step 5.5');
|
|
const step56 = content.indexOf('Step 5.6');
|
|
const step6 = content.indexOf('Step 6:');
|
|
assert.ok(step55 !== -1, 'Step 5.5 must exist');
|
|
assert.ok(step56 !== -1, 'Step 5.6 must exist');
|
|
assert.ok(step6 !== -1, 'Step 6 must exist');
|
|
assert.ok(step56 > step55, 'Step 5.6 must appear after Step 5.5');
|
|
assert.ok(step56 < step6, 'Step 5.6 must appear before Step 6');
|
|
});
|
|
|
|
test('Step 5.6 is gated on USE_WORKTREES', () => {
|
|
const step56Start = content.indexOf('Step 5.6');
|
|
const step6Start = content.indexOf('Step 6:', step56Start);
|
|
const step56Block = content.slice(step56Start, step6Start);
|
|
assert.ok(
|
|
step56Block.includes('USE_WORKTREES'),
|
|
'Step 5.6 must be gated on USE_WORKTREES — only commit pre-dispatch in worktree mode'
|
|
);
|
|
});
|
|
|
|
test('Step 5.6 is gated on commit_docs', () => {
|
|
const step56Start = content.indexOf('Step 5.6');
|
|
const step6Start = content.indexOf('Step 6:', step56Start);
|
|
const step56Block = content.slice(step56Start, step6Start);
|
|
assert.ok(
|
|
step56Block.includes('commit_docs'),
|
|
'Step 5.6 must respect commit_docs config — skip pre-dispatch commit when commit_docs is false'
|
|
);
|
|
});
|
|
|
|
test('Step 5.6 stages and commits PLAN.md', () => {
|
|
const step56Start = content.indexOf('Step 5.6');
|
|
const step6Start = content.indexOf('Step 6:', step56Start);
|
|
const step56Block = content.slice(step56Start, step6Start);
|
|
assert.ok(
|
|
step56Block.includes('PLAN.md'),
|
|
'Step 5.6 must reference PLAN.md in the pre-dispatch commit'
|
|
);
|
|
assert.ok(
|
|
step56Block.includes('git add') || step56Block.includes('git commit'),
|
|
'Step 5.6 must include git add/commit to stage and commit PLAN.md'
|
|
);
|
|
});
|
|
|
|
test('Step 5.6 uses --no-verify to avoid hook interference', () => {
|
|
const step56Start = content.indexOf('Step 5.6');
|
|
const step6Start = content.indexOf('Step 6:', step56Start);
|
|
const step56Block = content.slice(step56Start, step6Start);
|
|
assert.ok(
|
|
step56Block.includes('--no-verify'),
|
|
'Step 5.6 pre-dispatch commit must use --no-verify to avoid hook interference'
|
|
);
|
|
});
|
|
|
|
test('executor prompt references PLAN.md via relative (worktree-rooted) path', () => {
|
|
// QUICK_DIR is always set to ".planning/quick/..." (relative) so ${QUICK_DIR}/...PLAN.md
|
|
// resolves relative to the worktree root, not the main repo absolute path.
|
|
// Verify the executor prompt uses QUICK_DIR variable (not a hardcoded absolute path).
|
|
const executorTask = content.indexOf('subagent_type="gsd-executor"');
|
|
assert.ok(executorTask !== -1, 'executor Task() spawn must exist');
|
|
// Find the files_to_read block near the executor spawn
|
|
const filesBlock = content.lastIndexOf('<files_to_read>', executorTask);
|
|
const filesBlockEnd = content.indexOf('</files_to_read>', filesBlock);
|
|
const filesContent = content.slice(filesBlock, filesBlockEnd);
|
|
assert.ok(
|
|
filesContent.includes('QUICK_DIR') || filesContent.includes('.planning/quick'),
|
|
'executor files_to_read must reference PLAN.md via relative QUICK_DIR path'
|
|
);
|
|
assert.ok(
|
|
!filesContent.match(/\/home\/|\/Users\/|\/root\//),
|
|
'executor files_to_read must NOT contain hardcoded absolute paths'
|
|
);
|
|
});
|
|
});
|