mirror of
https://github.com/glittercowboy/get-shit-done
synced 2026-05-14 02:56:38 +02:00
* feat(#2982): extend no-source-grep lint to catch var-binding readFileSync.includes() The base lint (scripts/lint-no-source-grep.cjs) only catches readFileSync(...).<text-method>() chained directly. The much more common var-binding form escapes it: const src = fs.readFileSync(p, 'utf8'); // 50 lines later if (src.includes('foo')) {} // ← still grep, lint missed it Scan of the test suite found ~141 files using this pattern. Implementation built TDD per #2982 with structured-IR assertions: scripts/lint-no-source-grep-extras.cjs - detectVarBindingViolations(src) — pure detector, two passes: pass 1 collects vars bound from readFileSync, pass 2 finds any <var>.<includes|startsWith|endsWith|match|search>( on those vars. - detectWrappedAssertOkMatch(src) — flags assert.ok(<expr>.match(...)) which escapes the assert.match rule. - VIOLATION enum exposes stable codes for tests to assert on. scripts/lint-no-source-grep.cjs - Wires the new detectors into the existing per-file check; one additional violation row per file with the first 3 sample tokens. tests/bug-2982-lint-var-binding.test.cjs - 13 tests, all assertions on typed VIOLATION enum / structured records. Covers all 5 text-match methods, multi-var, no-bind, string literal (must NOT trigger), wrapped assert.ok(.match), and assert.match (must NOT double-flag). Migration backlog (#2974 expanded scope): - 42 files annotated `// allow-test-rule: source-text-is-the-product` (legitimate — they read .md/.json/.yml files whose deployed text IS the product) - 3 files annotated `// allow-test-rule: pending-migration-to-typed-ir [#2974]` (read .cjs/.js source — clear migration debt) - 95 files annotated `pending-migration-to-typed-ir [#2974]` with `Per-file review may reclassify as source-text-is-the-product during migration` (mixed — manual review under #2974) After this lands the lint reports 0 violations on main; new violations in PRs surface immediately. Closes #2982 Refs #2974 * test(#2982): fix truncated test name per CR The label ended with a bare '(' from a copy-paste mishap. Now reads 'does NOT flag .matchAll(...) — matchAll is not match, so assert.ok(.matchAll(...)) is not flagged'. * chore(#2982): add changeset fragment for PR #2985 * chore(#2982): add changeset fragment for PR #2985
68 lines
2.8 KiB
JavaScript
68 lines
2.8 KiB
JavaScript
// allow-test-rule: pending-migration-to-typed-ir [#2974]
|
|
// Tracked in #2974 for migration to typed-IR assertions per CONTRIBUTING.md
|
|
// "Prohibited: Raw Text Matching on Test Outputs". Per-file review may
|
|
// reclassify some entries as source-text-is-the-product during migration.
|
|
|
|
/**
|
|
* Execute-phase active flag prompt tests
|
|
*
|
|
* Guards against prompt wording that makes optional flags look active by default.
|
|
* This is especially important for weaker runtimes that may infer `--gaps-only`
|
|
* from the command docs instead of the literal user arguments.
|
|
*/
|
|
|
|
const { test, describe } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const COMMAND_PATH = path.join(__dirname, '..', 'commands', 'gsd', 'execute-phase.md');
|
|
|
|
describe('execute-phase command: active flags are explicit', () => {
|
|
test('command file exists', () => {
|
|
assert.ok(fs.existsSync(COMMAND_PATH), 'commands/gsd/execute-phase.md should exist');
|
|
});
|
|
|
|
test('objective says documented flags are not implied active', () => {
|
|
const content = fs.readFileSync(COMMAND_PATH, 'utf-8');
|
|
const objectiveMatch = content.match(/<objective>([\s\S]*?)<\/objective>/);
|
|
assert.ok(objectiveMatch, 'should have <objective> section');
|
|
assert.ok(
|
|
objectiveMatch[1].includes('available behaviors, not implied active behaviors'),
|
|
'objective should state that documented flags are not automatically active'
|
|
);
|
|
assert.ok(
|
|
objectiveMatch[1].includes('appears in `$ARGUMENTS`'),
|
|
'objective should tie flag activation to literal $ARGUMENTS presence'
|
|
);
|
|
});
|
|
|
|
test('context separates available flags from active flags', () => {
|
|
const content = fs.readFileSync(COMMAND_PATH, 'utf-8');
|
|
assert.ok(
|
|
content.includes('Available optional flags (documentation only'),
|
|
'context should clearly label flags as documentation only'
|
|
);
|
|
assert.ok(
|
|
content.includes('Active flags must be derived from `$ARGUMENTS`'),
|
|
'context should have a separate active-flags section'
|
|
);
|
|
});
|
|
|
|
test('context explicitly warns against inferring inactive flags', () => {
|
|
const content = fs.readFileSync(COMMAND_PATH, 'utf-8');
|
|
assert.ok(
|
|
content.includes('Do not infer that a flag is active just because it is documented in this prompt'),
|
|
'context should forbid inferring flags from documentation alone'
|
|
);
|
|
assert.ok(
|
|
content.includes('`--interactive` is active only if the literal `--interactive` token is present in `$ARGUMENTS`'),
|
|
'context should apply the same active-flag rule to --interactive'
|
|
);
|
|
assert.ok(
|
|
content.includes('If none of these tokens appear, run the standard full-phase execution flow'),
|
|
'context should define the no-flags fallback behavior'
|
|
);
|
|
});
|
|
});
|