mirror of
https://github.com/glittercowboy/get-shit-done
synced 2026-05-13 18:46:38 +02:00
918f987a19
* feat(#2982): extend no-source-grep lint to catch var-binding readFileSync.includes() The base lint (scripts/lint-no-source-grep.cjs) only catches readFileSync(...).<text-method>() chained directly. The much more common var-binding form escapes it: const src = fs.readFileSync(p, 'utf8'); // 50 lines later if (src.includes('foo')) {} // ← still grep, lint missed it Scan of the test suite found ~141 files using this pattern. Implementation built TDD per #2982 with structured-IR assertions: scripts/lint-no-source-grep-extras.cjs - detectVarBindingViolations(src) — pure detector, two passes: pass 1 collects vars bound from readFileSync, pass 2 finds any <var>.<includes|startsWith|endsWith|match|search>( on those vars. - detectWrappedAssertOkMatch(src) — flags assert.ok(<expr>.match(...)) which escapes the assert.match rule. - VIOLATION enum exposes stable codes for tests to assert on. scripts/lint-no-source-grep.cjs - Wires the new detectors into the existing per-file check; one additional violation row per file with the first 3 sample tokens. tests/bug-2982-lint-var-binding.test.cjs - 13 tests, all assertions on typed VIOLATION enum / structured records. Covers all 5 text-match methods, multi-var, no-bind, string literal (must NOT trigger), wrapped assert.ok(.match), and assert.match (must NOT double-flag). Migration backlog (#2974 expanded scope): - 42 files annotated `// allow-test-rule: source-text-is-the-product` (legitimate — they read .md/.json/.yml files whose deployed text IS the product) - 3 files annotated `// allow-test-rule: pending-migration-to-typed-ir [#2974]` (read .cjs/.js source — clear migration debt) - 95 files annotated `pending-migration-to-typed-ir [#2974]` with `Per-file review may reclassify as source-text-is-the-product during migration` (mixed — manual review under #2974) After this lands the lint reports 0 violations on main; new violations in PRs surface immediately. Closes #2982 Refs #2974 * test(#2982): fix truncated test name per CR The label ended with a bare '(' from a copy-paste mishap. Now reads 'does NOT flag .matchAll(...) — matchAll is not match, so assert.ok(.matchAll(...)) is not flagged'. * chore(#2982): add changeset fragment for PR #2985 * chore(#2982): add changeset fragment for PR #2985
78 lines
3.8 KiB
JavaScript
78 lines
3.8 KiB
JavaScript
// allow-test-rule: pending-migration-to-typed-ir [#2974]
|
|
// Tracked in #2974 for migration to typed-IR assertions per CONTRIBUTING.md
|
|
// "Prohibited: Raw Text Matching on Test Outputs". Per-file review may
|
|
// reclassify some entries as source-text-is-the-product during migration.
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
describe('explore command', () => {
|
|
test('command file exists', () => {
|
|
const p = path.join(__dirname, '..', 'commands', 'gsd', 'explore.md');
|
|
assert.ok(fs.existsSync(p), 'commands/gsd/explore.md should exist');
|
|
});
|
|
|
|
test('command file has required frontmatter', () => {
|
|
const p = path.join(__dirname, '..', 'commands', 'gsd', 'explore.md');
|
|
const content = fs.readFileSync(p, 'utf-8');
|
|
assert.ok(content.includes('name: gsd:explore'), 'Command must have name frontmatter');
|
|
assert.ok(content.includes('description:'), 'Command must have description frontmatter');
|
|
assert.ok(content.includes('allowed-tools:'), 'Command must have allowed-tools frontmatter');
|
|
});
|
|
|
|
test('workflow file exists', () => {
|
|
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'explore.md');
|
|
assert.ok(fs.existsSync(p), 'workflows/explore.md should exist');
|
|
});
|
|
|
|
test('workflow references questioning.md and domain-probes.md', () => {
|
|
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'explore.md');
|
|
const content = fs.readFileSync(p, 'utf-8');
|
|
assert.ok(content.includes('questioning.md'), 'Workflow must reference questioning.md');
|
|
assert.ok(content.includes('domain-probes.md'), 'Workflow must reference domain-probes.md');
|
|
});
|
|
|
|
test('workflow documents all 6 output types', () => {
|
|
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'explore.md');
|
|
const content = fs.readFileSync(p, 'utf-8');
|
|
assert.ok(content.includes('Note'), 'Workflow must document Note output type');
|
|
assert.ok(content.includes('Todo'), 'Workflow must document Todo output type');
|
|
assert.ok(content.includes('Seed'), 'Workflow must document Seed output type');
|
|
assert.ok(content.includes('Research question'), 'Workflow must document Research question output type');
|
|
assert.ok(content.includes('Requirement'), 'Workflow must document Requirement output type');
|
|
assert.ok(content.includes('New phase') || content.includes('phase'), 'Workflow must document New phase output type');
|
|
});
|
|
|
|
test('workflow enforces one question at a time principle', () => {
|
|
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'explore.md');
|
|
const content = fs.readFileSync(p, 'utf-8');
|
|
assert.ok(content.includes('one question at a time'), 'Workflow must mention "one question at a time" principle');
|
|
});
|
|
|
|
test('workflow requires user confirmation before writing artifacts', () => {
|
|
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'explore.md');
|
|
const content = fs.readFileSync(p, 'utf-8');
|
|
assert.ok(
|
|
content.includes('explicit user selection') || content.includes('Never write artifacts without'),
|
|
'Workflow must require user confirmation before writing artifacts'
|
|
);
|
|
});
|
|
|
|
test('workflow respects commit_docs config', () => {
|
|
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'explore.md');
|
|
const content = fs.readFileSync(p, 'utf-8');
|
|
assert.ok(content.includes('commit_docs'), 'Workflow must respect commit_docs configuration');
|
|
});
|
|
|
|
test('command references the workflow via execution_context', () => {
|
|
const p = path.join(__dirname, '..', 'commands', 'gsd', 'explore.md');
|
|
const content = fs.readFileSync(p, 'utf-8');
|
|
assert.ok(
|
|
content.includes('workflows/explore.md'),
|
|
'Command must reference workflows/explore.md in execution_context'
|
|
);
|
|
});
|
|
});
|