mirror of
https://github.com/glittercowboy/get-shit-done
synced 2026-05-13 18:46:38 +02:00
918f987a19
* feat(#2982): extend no-source-grep lint to catch var-binding readFileSync.includes() The base lint (scripts/lint-no-source-grep.cjs) only catches readFileSync(...).<text-method>() chained directly. The much more common var-binding form escapes it: const src = fs.readFileSync(p, 'utf8'); // 50 lines later if (src.includes('foo')) {} // ← still grep, lint missed it Scan of the test suite found ~141 files using this pattern. Implementation built TDD per #2982 with structured-IR assertions: scripts/lint-no-source-grep-extras.cjs - detectVarBindingViolations(src) — pure detector, two passes: pass 1 collects vars bound from readFileSync, pass 2 finds any <var>.<includes|startsWith|endsWith|match|search>( on those vars. - detectWrappedAssertOkMatch(src) — flags assert.ok(<expr>.match(...)) which escapes the assert.match rule. - VIOLATION enum exposes stable codes for tests to assert on. scripts/lint-no-source-grep.cjs - Wires the new detectors into the existing per-file check; one additional violation row per file with the first 3 sample tokens. tests/bug-2982-lint-var-binding.test.cjs - 13 tests, all assertions on typed VIOLATION enum / structured records. Covers all 5 text-match methods, multi-var, no-bind, string literal (must NOT trigger), wrapped assert.ok(.match), and assert.match (must NOT double-flag). Migration backlog (#2974 expanded scope): - 42 files annotated `// allow-test-rule: source-text-is-the-product` (legitimate — they read .md/.json/.yml files whose deployed text IS the product) - 3 files annotated `// allow-test-rule: pending-migration-to-typed-ir [#2974]` (read .cjs/.js source — clear migration debt) - 95 files annotated `pending-migration-to-typed-ir [#2974]` with `Per-file review may reclassify as source-text-is-the-product during migration` (mixed — manual review under #2974) After this lands the lint reports 0 violations on main; new violations in PRs surface immediately. Closes #2982 Refs #2974 * test(#2982): fix truncated test name per CR The label ended with a bare '(' from a copy-paste mishap. Now reads 'does NOT flag .matchAll(...) — matchAll is not match, so assert.ok(.matchAll(...)) is not flagged'. * chore(#2982): add changeset fragment for PR #2985 * chore(#2982): add changeset fragment for PR #2985
86 lines
2.9 KiB
JavaScript
86 lines
2.9 KiB
JavaScript
// allow-test-rule: pending-migration-to-typed-ir [#2974]
|
|
// Tracked in #2974 for migration to typed-IR assertions per CONTRIBUTING.md
|
|
// "Prohibited: Raw Text Matching on Test Outputs". Do not copy this pattern.
|
|
|
|
/**
|
|
* Regression tests for OpenCode permission config handling.
|
|
*
|
|
* Ensures the installer does not crash when opencode.json uses the valid
|
|
* top-level string form: "permission": "allow", and that path-specific
|
|
* permissions are written against the actual resolved install directory.
|
|
*/
|
|
|
|
process.env.GSD_TEST_MODE = '1';
|
|
|
|
const { test, describe, beforeEach, afterEach } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const { createTempDir, cleanup } = require('./helpers.cjs');
|
|
const { configureOpencodePermissions } = require('../bin/install.js');
|
|
|
|
const installSrc = fs.readFileSync(path.join(__dirname, '..', 'bin', 'install.js'), 'utf8');
|
|
|
|
const envKeys = ['OPENCODE_CONFIG_DIR', 'OPENCODE_CONFIG', 'XDG_CONFIG_HOME'];
|
|
const originalEnv = Object.fromEntries(envKeys.map((key) => [key, process.env[key]]));
|
|
|
|
function restoreEnv(snapshot) {
|
|
for (const key of envKeys) {
|
|
if (snapshot[key] === undefined) {
|
|
delete process.env[key];
|
|
} else {
|
|
process.env[key] = snapshot[key];
|
|
}
|
|
}
|
|
}
|
|
|
|
describe('configureOpencodePermissions', () => {
|
|
let configDir;
|
|
|
|
beforeEach(() => {
|
|
configDir = createTempDir('gsd-opencode-');
|
|
});
|
|
|
|
afterEach(() => {
|
|
cleanup(configDir);
|
|
restoreEnv(originalEnv);
|
|
});
|
|
|
|
test('does not crash or rewrite top-level string permissions', () => {
|
|
const configPath = path.join(configDir, 'opencode.json');
|
|
const original = JSON.stringify({
|
|
$schema: 'https://opencode.ai/config.json',
|
|
permission: 'allow',
|
|
skills: { paths: ['/tmp/skills'] },
|
|
}, null, 2) + '\n';
|
|
|
|
fs.writeFileSync(configPath, original);
|
|
process.env.OPENCODE_CONFIG_DIR = configDir;
|
|
|
|
assert.doesNotThrow(() => configureOpencodePermissions(true, configDir));
|
|
assert.strictEqual(fs.readFileSync(configPath, 'utf8'), original);
|
|
});
|
|
|
|
test('adds path-specific read and external_directory permissions for object configs', () => {
|
|
const configPath = path.join(configDir, 'opencode.json');
|
|
fs.writeFileSync(configPath, JSON.stringify({ permission: {} }, null, 2) + '\n');
|
|
process.env.OPENCODE_CONFIG_DIR = configDir;
|
|
|
|
configureOpencodePermissions(true, configDir);
|
|
|
|
const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
|
|
const gsdPath = `${configDir.replace(/\\/g, '/')}/get-shit-done/*`;
|
|
|
|
assert.strictEqual(config.permission.read[gsdPath], 'allow');
|
|
assert.strictEqual(config.permission.external_directory[gsdPath], 'allow');
|
|
});
|
|
|
|
test('finishInstall passes the actual config dir to OpenCode permissions', () => {
|
|
assert.ok(
|
|
installSrc.includes('configureOpencodePermissions(isGlobal, configDir);'),
|
|
'OpenCode permission config uses actual install dir'
|
|
);
|
|
});
|
|
});
|