mirror of
https://github.com/glittercowboy/get-shit-done
synced 2026-05-15 11:36:37 +02:00
* feat(#2982): extend no-source-grep lint to catch var-binding readFileSync.includes() The base lint (scripts/lint-no-source-grep.cjs) only catches readFileSync(...).<text-method>() chained directly. The much more common var-binding form escapes it: const src = fs.readFileSync(p, 'utf8'); // 50 lines later if (src.includes('foo')) {} // ← still grep, lint missed it Scan of the test suite found ~141 files using this pattern. Implementation built TDD per #2982 with structured-IR assertions: scripts/lint-no-source-grep-extras.cjs - detectVarBindingViolations(src) — pure detector, two passes: pass 1 collects vars bound from readFileSync, pass 2 finds any <var>.<includes|startsWith|endsWith|match|search>( on those vars. - detectWrappedAssertOkMatch(src) — flags assert.ok(<expr>.match(...)) which escapes the assert.match rule. - VIOLATION enum exposes stable codes for tests to assert on. scripts/lint-no-source-grep.cjs - Wires the new detectors into the existing per-file check; one additional violation row per file with the first 3 sample tokens. tests/bug-2982-lint-var-binding.test.cjs - 13 tests, all assertions on typed VIOLATION enum / structured records. Covers all 5 text-match methods, multi-var, no-bind, string literal (must NOT trigger), wrapped assert.ok(.match), and assert.match (must NOT double-flag). Migration backlog (#2974 expanded scope): - 42 files annotated `// allow-test-rule: source-text-is-the-product` (legitimate — they read .md/.json/.yml files whose deployed text IS the product) - 3 files annotated `// allow-test-rule: pending-migration-to-typed-ir [#2974]` (read .cjs/.js source — clear migration debt) - 95 files annotated `pending-migration-to-typed-ir [#2974]` with `Per-file review may reclassify as source-text-is-the-product during migration` (mixed — manual review under #2974) After this lands the lint reports 0 violations on main; new violations in PRs surface immediately. Closes #2982 Refs #2974 * test(#2982): fix truncated test name per CR The label ended with a bare '(' from a copy-paste mishap. Now reads 'does NOT flag .matchAll(...) — matchAll is not match, so assert.ok(.matchAll(...)) is not flagged'. * chore(#2982): add changeset fragment for PR #2985 * chore(#2982): add changeset fragment for PR #2985
291 lines
11 KiB
JavaScript
291 lines
11 KiB
JavaScript
// allow-test-rule: pending-migration-to-typed-ir [#2974]
|
|
// Tracked in #2974 for migration to typed-IR assertions per CONTRIBUTING.md
|
|
// "Prohibited: Raw Text Matching on Test Outputs". Per-file review may
|
|
// reclassify some entries as source-text-is-the-product during migration.
|
|
|
|
/**
|
|
* GSD Tools Tests - Kilo Install Plumbing
|
|
*
|
|
* Tests for Kilo runtime directory resolution, config paths,
|
|
* permission config, and installer source integration.
|
|
*/
|
|
|
|
process.env.GSD_TEST_MODE = '1';
|
|
|
|
const { test, describe, beforeEach, afterEach } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const os = require('node:os');
|
|
|
|
const { createTempProject, cleanup } = require('./helpers.cjs');
|
|
const {
|
|
getDirName,
|
|
getGlobalDir,
|
|
getConfigDirFromHome,
|
|
resolveKiloConfigPath,
|
|
configureKiloPermissions,
|
|
} = require('../bin/install.js');
|
|
|
|
describe('getDirName (Kilo)', () => {
|
|
test('returns .kilo for kilo', () => {
|
|
assert.strictEqual(getDirName('kilo'), '.kilo');
|
|
});
|
|
});
|
|
|
|
describe('getConfigDirFromHome (Kilo)', () => {
|
|
test('returns .kilo for local installs', () => {
|
|
assert.strictEqual(getConfigDirFromHome('kilo', false), "'.kilo'");
|
|
});
|
|
|
|
test('returns .config, kilo for global installs', () => {
|
|
assert.strictEqual(getConfigDirFromHome('kilo', true), "'.config', 'kilo'");
|
|
});
|
|
});
|
|
|
|
describe('getGlobalDir (Kilo)', () => {
|
|
let savedEnv;
|
|
|
|
beforeEach(() => {
|
|
savedEnv = {
|
|
KILO_CONFIG_DIR: process.env.KILO_CONFIG_DIR,
|
|
KILO_CONFIG: process.env.KILO_CONFIG,
|
|
XDG_CONFIG_HOME: process.env.XDG_CONFIG_HOME,
|
|
};
|
|
|
|
delete process.env.KILO_CONFIG_DIR;
|
|
delete process.env.KILO_CONFIG;
|
|
delete process.env.XDG_CONFIG_HOME;
|
|
});
|
|
|
|
afterEach(() => {
|
|
if (savedEnv.KILO_CONFIG_DIR === undefined) {
|
|
delete process.env.KILO_CONFIG_DIR;
|
|
} else {
|
|
process.env.KILO_CONFIG_DIR = savedEnv.KILO_CONFIG_DIR;
|
|
}
|
|
|
|
if (savedEnv.KILO_CONFIG === undefined) {
|
|
delete process.env.KILO_CONFIG;
|
|
} else {
|
|
process.env.KILO_CONFIG = savedEnv.KILO_CONFIG;
|
|
}
|
|
|
|
if (savedEnv.XDG_CONFIG_HOME === undefined) {
|
|
delete process.env.XDG_CONFIG_HOME;
|
|
} else {
|
|
process.env.XDG_CONFIG_HOME = savedEnv.XDG_CONFIG_HOME;
|
|
}
|
|
});
|
|
|
|
test('returns ~/.config/kilo by default', () => {
|
|
assert.strictEqual(getGlobalDir('kilo'), path.join(os.homedir(), '.config', 'kilo'));
|
|
});
|
|
|
|
test('respects KILO_CONFIG_DIR env var', () => {
|
|
process.env.KILO_CONFIG_DIR = '~/custom-kilo';
|
|
assert.strictEqual(getGlobalDir('kilo'), path.join(os.homedir(), 'custom-kilo'));
|
|
});
|
|
|
|
test('falls back to XDG_CONFIG_HOME/kilo', () => {
|
|
process.env.XDG_CONFIG_HOME = '~/xdg-config';
|
|
assert.strictEqual(getGlobalDir('kilo'), path.join(os.homedir(), 'xdg-config', 'kilo'));
|
|
});
|
|
|
|
test('uses dirname(KILO_CONFIG) when KILO_CONFIG_DIR is unset', () => {
|
|
process.env.KILO_CONFIG = '~/profiles/work/kilo.jsonc';
|
|
assert.strictEqual(getGlobalDir('kilo'), path.join(os.homedir(), 'profiles', 'work'));
|
|
});
|
|
|
|
test('KILO_CONFIG_DIR takes precedence over KILO_CONFIG', () => {
|
|
process.env.KILO_CONFIG_DIR = '~/custom-kilo';
|
|
process.env.KILO_CONFIG = '~/profiles/work/kilo.jsonc';
|
|
assert.strictEqual(getGlobalDir('kilo'), path.join(os.homedir(), 'custom-kilo'));
|
|
});
|
|
|
|
test('explicit config-dir overrides env vars', () => {
|
|
process.env.KILO_CONFIG_DIR = '~/from-env';
|
|
process.env.XDG_CONFIG_HOME = '~/xdg-config';
|
|
assert.strictEqual(getGlobalDir('kilo', '/explicit/kilo'), '/explicit/kilo');
|
|
});
|
|
});
|
|
|
|
describe('Kilo config file helpers', () => {
|
|
let tmpDir;
|
|
|
|
beforeEach(() => {
|
|
tmpDir = createTempProject('gsd-kilo-');
|
|
});
|
|
|
|
afterEach(() => {
|
|
cleanup(tmpDir);
|
|
});
|
|
|
|
test('resolveKiloConfigPath prefers kilo.jsonc when present', () => {
|
|
const configDir = path.join(tmpDir, '.kilo');
|
|
fs.mkdirSync(configDir, { recursive: true });
|
|
fs.writeFileSync(path.join(configDir, 'kilo.jsonc'), '{\n // comment\n}\n');
|
|
|
|
assert.strictEqual(resolveKiloConfigPath(configDir), path.join(configDir, 'kilo.jsonc'));
|
|
});
|
|
|
|
test('resolveKiloConfigPath falls back to kilo.json', () => {
|
|
const configDir = path.join(tmpDir, '.kilo');
|
|
fs.mkdirSync(configDir, { recursive: true });
|
|
|
|
assert.strictEqual(resolveKiloConfigPath(configDir), path.join(configDir, 'kilo.json'));
|
|
});
|
|
});
|
|
|
|
describe('configureKiloPermissions', () => {
|
|
let tmpDir;
|
|
let configDir;
|
|
let savedEnv;
|
|
|
|
beforeEach(() => {
|
|
tmpDir = createTempProject('gsd-kilo-perms-');
|
|
configDir = path.join(tmpDir, '.config', 'kilo');
|
|
savedEnv = {
|
|
KILO_CONFIG_DIR: process.env.KILO_CONFIG_DIR,
|
|
XDG_CONFIG_HOME: process.env.XDG_CONFIG_HOME,
|
|
};
|
|
process.env.KILO_CONFIG_DIR = configDir;
|
|
delete process.env.XDG_CONFIG_HOME;
|
|
});
|
|
|
|
afterEach(() => {
|
|
if (savedEnv.KILO_CONFIG_DIR === undefined) {
|
|
delete process.env.KILO_CONFIG_DIR;
|
|
} else {
|
|
process.env.KILO_CONFIG_DIR = savedEnv.KILO_CONFIG_DIR;
|
|
}
|
|
|
|
if (savedEnv.XDG_CONFIG_HOME === undefined) {
|
|
delete process.env.XDG_CONFIG_HOME;
|
|
} else {
|
|
process.env.XDG_CONFIG_HOME = savedEnv.XDG_CONFIG_HOME;
|
|
}
|
|
|
|
cleanup(tmpDir);
|
|
});
|
|
|
|
test('writes GSD permissions to kilo.json when config is missing', () => {
|
|
configureKiloPermissions(true);
|
|
|
|
const configPath = path.join(configDir, 'kilo.json');
|
|
const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
|
|
const gsdPath = `${configDir.replace(/\\/g, '/')}/get-shit-done/*`;
|
|
|
|
assert.strictEqual(config.permission.read[gsdPath], 'allow');
|
|
assert.strictEqual(config.permission.external_directory[gsdPath], 'allow');
|
|
});
|
|
|
|
test('updates existing kilo.jsonc configs via JSONC parsing', () => {
|
|
fs.mkdirSync(configDir, { recursive: true });
|
|
const configPath = path.join(configDir, 'kilo.jsonc');
|
|
fs.writeFileSync(configPath, '{\n // existing config\n "permission": {\n "bash": "ask",\n },\n}\n');
|
|
|
|
configureKiloPermissions(true);
|
|
|
|
const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
|
|
const gsdPath = `${configDir.replace(/\\/g, '/')}/get-shit-done/*`;
|
|
|
|
assert.strictEqual(config.permission.bash, 'ask');
|
|
assert.strictEqual(config.permission.read[gsdPath], 'allow');
|
|
assert.strictEqual(config.permission.external_directory[gsdPath], 'allow');
|
|
});
|
|
|
|
test('writes permissions to an explicit config dir argument', () => {
|
|
const explicitDir = path.join(tmpDir, 'custom-kilo-config');
|
|
|
|
configureKiloPermissions(true, explicitDir);
|
|
|
|
const configPath = path.join(explicitDir, 'kilo.json');
|
|
const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
|
|
const gsdPath = `${explicitDir.replace(/\\/g, '/')}/get-shit-done/*`;
|
|
|
|
assert.strictEqual(config.permission.read[gsdPath], 'allow');
|
|
assert.strictEqual(config.permission.external_directory[gsdPath], 'allow');
|
|
});
|
|
});
|
|
|
|
describe('Source code integration (Kilo)', () => {
|
|
const src = fs.readFileSync(path.join(__dirname, '..', 'bin', 'install.js'), 'utf8');
|
|
const updateWorkflowSrc = fs.readFileSync(path.join(__dirname, '..', 'get-shit-done', 'workflows', 'update.md'), 'utf8');
|
|
// #2790: reapply-patches.md command was absorbed into update.md --reapply.
|
|
// The Kilo-specific env-var checks (KILO_CONFIG_DIR, KILO_CONFIG, XDG_CONFIG_HOME)
|
|
// now live in the update.md workflow (which covers both --sync and --reapply paths).
|
|
const reapplyPatchesSrc = updateWorkflowSrc;
|
|
|
|
test('--kilo flag parsing exists', () => {
|
|
assert.ok(src.includes("args.includes('--kilo')"), '--kilo flag parsed');
|
|
});
|
|
|
|
test('help text includes --kilo', () => {
|
|
assert.ok(src.includes('Install for Kilo only'), 'help text includes Kilo option');
|
|
});
|
|
|
|
test('--all array includes kilo', () => {
|
|
assert.ok(src.includes("'kilo'"), '--all includes kilo runtime');
|
|
});
|
|
|
|
test('promptRuntime runtimeMap has Kilo as option 11', () => {
|
|
// Structural assertion against exported runtimeMap rather than source-grep.
|
|
process.env.GSD_TEST_MODE = '1';
|
|
delete require.cache[require.resolve(path.join(__dirname, '..', 'bin', 'install.js'))];
|
|
const { runtimeMap } = require(path.join(__dirname, '..', 'bin', 'install.js'));
|
|
assert.strictEqual(runtimeMap['11'], 'kilo', 'runtimeMap has 11 -> kilo');
|
|
});
|
|
|
|
test('prompt text shows Kilo above OpenCode without marketing copy', () => {
|
|
// Call the exported prompt builder; assert against rendered text, not raw source.
|
|
process.env.GSD_TEST_MODE = '1';
|
|
delete require.cache[require.resolve(path.join(__dirname, '..', 'bin', 'install.js'))];
|
|
const { buildRuntimePromptText } = require(path.join(__dirname, '..', 'bin', 'install.js'));
|
|
const promptText = buildRuntimePromptText();
|
|
// Strip ANSI color codes so assertions don't depend on terminal escapes.
|
|
// eslint-disable-next-line no-control-regex
|
|
const plain = promptText.replace(/\x1b\[[0-9;]*m/g, '');
|
|
assert.ok(/\b11\)\s*Kilo\b/.test(plain), 'prompt lists Kilo as option 11');
|
|
const kiloIdx = plain.indexOf('11) Kilo');
|
|
const opencodeIdx = plain.indexOf('OpenCode');
|
|
assert.ok(kiloIdx > -1 && opencodeIdx > -1 && kiloIdx < opencodeIdx,
|
|
'Kilo appears above OpenCode in prompt');
|
|
assert.ok(!plain.includes('the #1 AI coding platform on OpenRouter'),
|
|
'prompt does not include marketing tagline');
|
|
});
|
|
|
|
test('hooks are skipped for Kilo', () => {
|
|
assert.ok(src.includes('!isOpencode && !isKilo'), 'hooks skip check includes kilo');
|
|
});
|
|
|
|
test('settings.json write excludes Kilo', () => {
|
|
assert.ok(src.includes('!isCodex && !isCopilot && !isKilo && !isCursor && !isWindsurf'), 'settings write excludes kilo');
|
|
});
|
|
|
|
test('agent path replacement does not exclude Kilo', () => {
|
|
assert.ok(src.includes('if (!isCopilot && !isAntigravity)'), 'generic agent path replacement still applies');
|
|
});
|
|
|
|
test('finishInstall passes the actual config dir to Kilo permissions', () => {
|
|
assert.ok(src.includes('configureKiloPermissions(isGlobal, configDir);'), 'Kilo permission config uses actual install dir');
|
|
});
|
|
|
|
test('uninstall cleans Kilo permissions from the resolved target dir', () => {
|
|
assert.ok(src.includes('const configPath = resolveKiloConfigPath(targetDir);'), 'Kilo uninstall cleanup uses targetDir');
|
|
});
|
|
|
|
test('update workflow checks preferred custom config dirs before defaults', () => {
|
|
assert.ok(updateWorkflowSrc.includes('PREFERRED_CONFIG_DIR'), 'workflow tracks preferred config dir');
|
|
assert.ok(updateWorkflowSrc.includes('kilo.jsonc'), 'workflow infers Kilo from config files');
|
|
assert.ok(updateWorkflowSrc.includes('ENV_RUNTIME_DIRS'), 'workflow checks env-derived config dirs');
|
|
assert.ok(updateWorkflowSrc.includes('KILO_CONFIG'), 'workflow checks KILO_CONFIG');
|
|
});
|
|
|
|
test('reapply-patches checks Kilo custom config env vars first', () => {
|
|
assert.ok(reapplyPatchesSrc.includes('KILO_CONFIG_DIR'), 'reapply-patches checks KILO_CONFIG_DIR');
|
|
assert.ok(reapplyPatchesSrc.includes('KILO_CONFIG'), 'reapply-patches checks KILO_CONFIG');
|
|
assert.ok(reapplyPatchesSrc.includes('XDG_CONFIG_HOME'), 'reapply-patches checks XDG_CONFIG_HOME');
|
|
});
|
|
});
|