Files
get-shit-done/tests/planner-decomposition.test.cjs
Rezolv c5b1445529 feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A) (#2341)
* feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A)

Golden/read-only parity tests and registry alignment, query handler fixes
(check-completion, state-mutation, commit, validate, summary, etc.), and
WAITING.json dual-write for .gsd/.planning readers.

Refs gsd-build/get-shit-done#2341

* fix(sdk): getMilestoneInfo matches GSD ROADMAP (🟡, last bold, STATE fallback)

- Recognize in-flight 🟡 milestone bullets like 🚧.
- Derive from last **vX.Y Title** before ## Phases when emoji absent.
- Fall back to STATE.md milestone when ROADMAP is missing; use last bare vX.Y
  in cleaned text instead of first (avoids v1.0 from shipped list).
- Fixes init.execute-phase milestone_version and buildStateFrontmatter after
  state.begin-phase (syncStateFrontmatter).

* feat(sdk): phase list, plan task structure, requirements extract handlers

- Register phase.list-plans, phase.list-artifacts, plan.task-structure,
  requirements.extract-from-plans (SDK-only; golden-policy exceptions).
- Add unit tests; document in QUERY-HANDLERS.md.
- writeProfile: honor --output, render dimensions, return profile_path and dimensions_scored.

* feat(sdk): centralize getGsdAgentsDir in query helpers

Extract agent directory resolution to helpers (GSD_AGENTS_DIR, primary
~/.claude/agents, legacy path). Use from init and docs-init init bundles.

docs(15): add 15-CONTEXT for autonomous phase-15 run.

* feat(sdk): query CLI CJS fallback and session correlation

- createRegistry(eventStream, sessionId) threads correlation into mutation events
- gsd-sdk query falls back to gsd-tools.cjs when no native handler matches
  (disable with GSD_QUERY_FALLBACK=off); stderr bridge warnings
- Export createRegistry from @gsd-build/sdk; add sdk/README.md
- Update QUERY-HANDLERS.md and registry module docs for fallback + sessionId
- Agents: prefer node dist/cli.js query over cat/grep for STATE and plans

* fix(sdk): init phase_found parity, docs-init agents path, state field extract

- Normalize findPhase not-found to null before roadmap fallback (matches findPhaseInternal)

- docs-init: use detectRuntime + resolveAgentsDir for checkAgentsInstalled

- state.cjs stateExtractField: horizontal whitespace only after colon (YAML progress guard)

- Tests: commit_docs default true; config-get golden uses temp config; golden integration green

Refs: #2302

* refactor(sdk): share SessionJsonlRecord in profile-extract-messages

CodeRabbit nit: dedupe JSONL record shape for isGenuineUserMessage and streamExtractMessages.

* fix(sdk): address CodeRabbit major threads (paths, gates, audit, verify)

- Resolve @file: and CLI JSON indirection relative to projectDir; guard empty normalized query command

- plan.task-structure + intel extract/patch-meta: resolvePathUnderProject containment

- check.config-gates: safe string booleans; plan_checker alias precedence over plan_check default

- state.validate/sync: phaseTokenMatches + comparePhaseNum ordering

- verify.schema-drift: token match phase dirs; files_modified from parsed frontmatter

- audit-open: has_scan_errors, unreadable rows, human report when scans fail

- requirements PLANNED key PLAN for root PLAN.md; gsd-tools timeout note

- ingest-docs: repo-root path containment; classifier output slug-hash

Golden parity test strips has_scan_errors until CJS adds field.

* fix: Resolve CodeRabbit security and quality findings
- Secure intel.ts and cli.ts against path traversal
- Catch and validate git add status in commit.ts
- Expand roadmap milestone marker extraction
- Fix parsing array-of-objects in frontmatter YAML
- Fix unhandled config evaluations
- Improve coverage test parity mapping

* test: raise planner character extraction limit to 48K

* fix(sdk): resolve TS build error in docs-init passing config
2026-04-20 18:09:02 -04:00

136 lines
6.2 KiB
JavaScript

/**
* Tests for modular decomposition of agents/gsd-planner.md
*
* Verifies that:
* 1. gsd-planner.md stays under the 100K agent file threshold
* 2. gsd-planner.md is under 45K chars (proving the three mode sections were extracted)
* 3. The three reference files exist
* 4. gsd-planner.md contains reference pointers to each extracted file
* 5. Each reference file contains key content from the original mode section
*/
'use strict';
const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
const PROJECT_ROOT = path.join(__dirname, '..');
// ─── Size thresholds ─────────────────────────────────────────────────────────
const AGENT_FILE_SIZE_LIMIT = 100 * 1024; // 100K — appropriate for version-controlled source
const PLANNER_EXTRACTED_LIMIT = 48 * 1024; // 48K — proves extraction happened
// ─── File paths ──────────────────────────────────────────────────────────────
const PLANNER_PATH = path.join(PROJECT_ROOT, 'agents', 'gsd-planner.md');
const GAP_CLOSURE_REF = path.join(PROJECT_ROOT, 'get-shit-done', 'references', 'planner-gap-closure.md');
const REVISION_REF = path.join(PROJECT_ROOT, 'get-shit-done', 'references', 'planner-revision.md');
const REVIEWS_REF = path.join(PROJECT_ROOT, 'get-shit-done', 'references', 'planner-reviews.md');
// ─── gsd-planner.md size ─────────────────────────────────────────────────────
describe('gsd-planner.md size constraints', () => {
test('planner file exists', () => {
assert.ok(fs.existsSync(PLANNER_PATH), `Missing: ${PLANNER_PATH}`);
});
test('planner is under 100K chars (agent file threshold)', () => {
const raw = fs.readFileSync(PLANNER_PATH, 'utf-8');
// Normalize CRLF → LF before measuring — Windows checkouts inflate length by ~1 char/line
const content = raw.replace(/\r\n/g, '\n').replace(/\r/g, '\n');
assert.ok(
content.length < AGENT_FILE_SIZE_LIMIT,
`gsd-planner.md is ${content.length} chars, exceeds 100K agent threshold`
);
});
test('planner is under 45K chars (proves mode sections were extracted)', () => {
const raw = fs.readFileSync(PLANNER_PATH, 'utf-8');
// Normalize CRLF → LF before measuring — Windows checkouts inflate length by ~1 char/line
const content = raw.replace(/\r\n/g, '\n').replace(/\r/g, '\n');
assert.ok(
content.length < PLANNER_EXTRACTED_LIMIT,
`gsd-planner.md is ${content.length} chars, expected < 45K after extracting mode sections`
);
});
});
// ─── Reference files exist ───────────────────────────────────────────────────
describe('extracted reference files exist', () => {
test('planner-gap-closure.md exists', () => {
assert.ok(fs.existsSync(GAP_CLOSURE_REF), `Missing: ${GAP_CLOSURE_REF}`);
});
test('planner-revision.md exists', () => {
assert.ok(fs.existsSync(REVISION_REF), `Missing: ${REVISION_REF}`);
});
test('planner-reviews.md exists', () => {
assert.ok(fs.existsSync(REVIEWS_REF), `Missing: ${REVIEWS_REF}`);
});
});
// ─── gsd-planner.md contains reference pointers ──────────────────────────────
describe('gsd-planner.md contains reference pointers to extracted files', () => {
let plannerContent;
test('planner references planner-gap-closure.md', () => {
plannerContent = plannerContent || fs.readFileSync(PLANNER_PATH, 'utf-8');
assert.ok(
plannerContent.includes('planner-gap-closure.md'),
'gsd-planner.md must reference planner-gap-closure.md'
);
});
test('planner references planner-revision.md', () => {
plannerContent = plannerContent || fs.readFileSync(PLANNER_PATH, 'utf-8');
assert.ok(
plannerContent.includes('planner-revision.md'),
'gsd-planner.md must reference planner-revision.md'
);
});
test('planner references planner-reviews.md', () => {
plannerContent = plannerContent || fs.readFileSync(PLANNER_PATH, 'utf-8');
assert.ok(
plannerContent.includes('planner-reviews.md'),
'gsd-planner.md must reference planner-reviews.md'
);
});
});
// ─── Reference files contain key content ────────────────────────────────────
describe('reference files contain key content from original mode sections', () => {
test('planner-gap-closure.md contains gap closure content', () => {
const content = fs.readFileSync(GAP_CLOSURE_REF, 'utf-8');
const hasGapContent = content.toLowerCase().includes('gap_closure') ||
content.toLowerCase().includes('gap closure') ||
content.includes('GAP CLOSURE') ||
content.includes('--gaps');
assert.ok(hasGapContent, 'planner-gap-closure.md must contain gap closure mode content');
});
test('planner-revision.md contains revision content', () => {
const content = fs.readFileSync(REVISION_REF, 'utf-8');
const hasRevisionContent = content.includes('revision') ||
content.includes('Revision') ||
content.includes('REVISION') ||
content.includes('revision_context');
assert.ok(hasRevisionContent, 'planner-revision.md must contain revision mode content');
});
test('planner-reviews.md contains reviews content', () => {
const content = fs.readFileSync(REVIEWS_REF, 'utf-8');
const hasReviewsContent = content.includes('reviews') ||
content.includes('Reviews') ||
content.includes('REVIEWS') ||
content.includes('REVIEWS.md');
assert.ok(hasReviewsContent, 'planner-reviews.md must contain reviews mode content');
});
});