mirror of
https://github.com/glittercowboy/get-shit-done
synced 2026-04-25 17:25:23 +02:00
2703422be8
* refactor(tests): standardize to node:assert/strict and t.after() per CONTRIBUTING.md
- Replace require('node:assert') with require('node:assert/strict') across
all 73 test files to enforce strict equality (no type coercion)
- Replace try/finally cleanup blocks with t.after() hooks in core.test.cjs
and hooks-opt-in.test.cjs per the test lifecycle standards
- Utility functions in codex-config and security-scan retain try/finally
as that is appropriate for per-function resource guards, not lifecycle hooks
Closes #1674
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* perf(tests): add --test-concurrency=4 to test runner for parallel file execution
Node.js --test-concurrency controls how many test files run as parallel child
processes. Set to 4 by default, configurable via TEST_CONCURRENCY env var.
Fixes tests at a known level rather than inheriting os.availableParallelism()
which varies across CI environments.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(security): allowlist verify.test.cjs in prompt-injection scanner
tests/verify.test.cjs uses <human>...</human> as GSD phase task-type
XML (meaning "a human should verify this step"), which matches the
scanner's fake-message-boundary pattern for LLM APIs. This is a
false positive — add it to the allowlist alongside the other test files
that legitimately contain injection-adjacent patterns.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
50 lines
2.0 KiB
JavaScript
50 lines
2.0 KiB
JavaScript
const { test, describe } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
describe('Playwright-MCP UI verification integration', () => {
|
|
test('verify-work.md mentions automated UI verification', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(__dirname, '..', 'get-shit-done', 'workflows', 'verify-work.md'), 'utf-8'
|
|
);
|
|
assert.ok(
|
|
content.toLowerCase().includes('playwright') || content.includes('automated') && content.includes('UI'),
|
|
'verify-work.md should mention automated UI verification option'
|
|
);
|
|
});
|
|
|
|
test('ui-review.md mentions Playwright-MCP when available', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(__dirname, '..', 'get-shit-done', 'workflows', 'ui-review.md'), 'utf-8'
|
|
);
|
|
assert.ok(
|
|
content.toLowerCase().includes('playwright') || content.includes('mcp__playwright'),
|
|
'ui-review.md should reference Playwright-MCP'
|
|
);
|
|
});
|
|
|
|
test('gsd-ui-auditor.md includes automated screenshot guidance', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(__dirname, '..', 'agents', 'gsd-ui-auditor.md'), 'utf-8'
|
|
);
|
|
assert.ok(
|
|
content.toLowerCase().includes('playwright') || content.includes('screenshot') || content.includes('automated'),
|
|
'gsd-ui-auditor.md should mention automated screenshot verification'
|
|
);
|
|
});
|
|
|
|
test('automated verification is optional/conditional (falls back to manual)', () => {
|
|
const verifyContent = fs.readFileSync(
|
|
path.join(__dirname, '..', 'get-shit-done', 'workflows', 'verify-work.md'), 'utf-8'
|
|
);
|
|
// Must include a fallback / "if available" conditional
|
|
const hasConditional =
|
|
verifyContent.includes('if available') ||
|
|
verifyContent.includes('when available') ||
|
|
verifyContent.includes('if Playwright') ||
|
|
verifyContent.includes('fall back');
|
|
assert.ok(hasConditional, 'Playwright integration must be conditional with manual fallback');
|
|
});
|
|
});
|