eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 10:07:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/HTML: Unregister ESO during finalize phase

Browse Source 
It is generally safer for GC cells to do cleanup work during the
finalize phase.
This commit is contained in:
Shannon Booth
2025-06-18 20:04:02 +12:00
committed by Jelle Raaijmakers
parent 3c0b125c1c
commit 00002c6443
Notes: github-actions[bot] 2025-06-18 11:09:44 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/00002c6443e
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5129
Reviewed-by: https://github.com/gmta ✅
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/HTML/Scripting/Environments.h
View File

@@ -76,7 +76,7 @@ struct EnvironmentSettingsObject : public Environment {
GC_CELL(EnvironmentSettingsObject, Environment);
public:
virtual ~EnvironmentSettingsObject() override;
virtual void finalize() override;
virtual void initialize(JS::Realm&) override;
// https://html.spec.whatwg.org/multipage/webappapis.html#concept-environment-target-browsing-context