eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-28 10:37:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibCore: Prevent UAF on event loop wake handles on Windows

Browse Source 
We were holding a reference to ThreadData, which could be destroyed
earlier than the EventLoop itself, causing other threads to UAF trying
to signal a wake.
This commit is contained in:
Zaggy1024
2026-02-27 08:20:13 -06:00
committed by Gregory Bertilson
parent 04e95b7dd1
commit 035b489266
Notes: github-actions[bot] 2026-03-02 23:09:07 +00:00 
Author: https://github.com/Zaggy1024
Commit: https://github.com/LadybirdBrowser/ladybird/commit/035b4892669
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8197
Reviewed-by: https://github.com/gmta ✅
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Libraries/LibCore/EventLoopImplementationWindows.cpp
View File

@@ -144,6 +144,7 @@ struct ThreadData {
EventLoopImplementationWindows::EventLoopImplementationWindows()
: m_wake_event(ThreadData::the()->wake_data->wait_event.handle)
{
VERIFY(m_wake_event);
}
EventLoopImplementationWindows::~EventLoopImplementationWindows()