eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Maintain easing keywords as KeywordStyleValue until use-time

Browse Source 
This excludes `step-end` and `step-start` which are expected to be
converted to the equivalent function at parse time.

We are expected to serialize these as the explicit keywords - previously
we would parse as `EasingStyleValue` and serialize equivalent functions
as the keywords. This caused issues as we would incorrectly serialize
even explicit functions as the keyword.

This also allows us to move the magic easing functions to
`EasingFunction` rather than `EasingStyleValue` which is a bit tidier
This commit is contained in:
Callum Law
2025-10-11 23:34:35 +13:00
committed by Sam Atkins
parent 755a576013
commit 03be70087d
Notes: github-actions[bot] 2025-10-20 10:29:02 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/03be70087d4
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6459
Reviewed-by: https://github.com/AtkinsSJ ✅
15 changed files with 210 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Libraries/LibWeb/CSS/StyleValues/EasingStyleValue.h
View File

@@ -19,8 +19,6 @@ namespace Web::CSS {
class EasingStyleValue final : public StyleValueWithDefaultOperators<EasingStyleValue> {
public:
struct Linear {
static Linear identity();
struct Stop {
ValueComparingNonnullRefPtr<StyleValue const> output;
ValueComparingRefPtr<StyleValue const> input;
@@ -36,11 +34,6 @@ public:
};
struct CubicBezier {
static CubicBezier ease();
static CubicBezier ease_in();
static CubicBezier ease_out();
static CubicBezier ease_in_out();
ValueComparingNonnullRefPtr<StyleValue const> x1;
ValueComparingNonnullRefPtr<StyleValue const> y1;
ValueComparingNonnullRefPtr<StyleValue const> x2;
@@ -63,9 +56,6 @@ public:
};
struct Steps {
static Steps step_start();
static Steps step_end();
ValueComparingNonnullRefPtr<StyleValue const> number_of_intervals;
StepPosition position;