eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 03:57:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Do not store resize observer entries in a plain vector

Browse Source 
This is not safe from GC. Unfortunately we cannot add a test to capture
the issue, as the allocation which may trigger GC is internal and not
observable from JS.
This commit is contained in:
Timothy Flynn
2024-10-31 11:30:24 -04:00
committed by Alexander Kalenik
parent be1d400369
commit 04648d93d4
Notes: github-actions[bot] 2024-10-31 23:37:30 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/04648d93d42
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2088
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibWeb/ResizeObserver/ResizeObserver.h
View File

@@ -31,7 +31,7 @@ public:
void unobserve(DOM::Element& target);
void disconnect();
void invoke_callback(Vector<JS::NonnullGCPtr<ResizeObserverEntry>>& entries) const;
void invoke_callback(ReadonlySpan<JS::NonnullGCPtr<ResizeObserverEntry>> entries) const;
Vector<JS::NonnullGCPtr<ResizeObservation>>& observation_targets() { return m_observation_targets; }
Vector<JS::NonnullGCPtr<ResizeObservation>>& active_targets() { return m_active_targets; }