eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/CSS: Generate canonical/compatible unit functions

Browse Source 
These are used by `CSSNumericValue.to(unit)` which attempts to convert
to the provided unit.
This commit is contained in:
Sam Atkins
2025-09-11 15:57:35 +01:00
committed by Jelle Raaijmakers
parent 5a42b7a40f
commit 050d3a58cf
Notes: github-actions[bot] 2025-09-12 11:46:57 +00:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/LadybirdBrowser/ladybird/commit/050d3a58cf1
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6162
Reviewed-by: https://github.com/gmta ✅
2 changed files with 36 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSUnits.cpp
View File

@@ -150,15 +150,20 @@ Optional<DimensionType> dimension_for_unit(StringView);
enum_generator.append(R"~~~(
enum class @dimension_name:titlecase@Unit : @enum_type@ {
)~~~");
units.for_each_member([&](auto& unit_name, auto&) {
units.for_each_member([&](auto& unit_name, auto& unit_value) {
auto& unit = unit_value.as_object();
if (unit.get_bool("is-canonical-unit"sv) == true)
enum_generator.set("canonical_unit:titlecase", title_casify(unit_name));
auto unit_generator = enum_generator.fork();
unit_generator.set("unit_name:titlecase", title_casify(unit_name));
unit_generator.appendln(" @unit_name:titlecase@,");
});
enum_generator.append(R"~~~(
};
constexpr @dimension_name:titlecase@Unit canonical_@dimension_name:snakecase@_unit() { return @dimension_name:titlecase@Unit::@canonical_unit:titlecase@; }
Optional<@dimension_name:titlecase@Unit> string_to_@dimension_name:snakecase@_unit(StringView);
FlyString to_string(@dimension_name:titlecase@Unit);
bool units_are_compatible(@dimension_name:titlecase@Unit, @dimension_name:titlecase@Unit);
double ratio_between_units(@dimension_name:titlecase@Unit, @dimension_name:titlecase@Unit);
)~~~");
});
@@ -263,6 +268,34 @@ FlyString to_string(@dimension_name:titlecase@Unit value)
}
}
bool units_are_compatible(@dimension_name:titlecase@Unit a, @dimension_name:titlecase@Unit b)
{
auto is_absolute = [](@dimension_name:titlecase@Unit unit) -> bool {
switch (unit) {
)~~~");
// https://drafts.csswg.org/css-values-4/#compatible-units
// NB: The spec describes two ways units can be compatible. Absolute ones always are, but it also lists em/px
// as compatible at computed value time. We should already have absolutized the units by then, but perhaps
// there is some case where we need to handle that here instead.
units.for_each_member([&](String const& unit_name, JsonValue const& unit_value) {
auto const& unit = unit_value.as_object();
if (unit.has("relative-to"sv))
return;
auto unit_generator = dimension_generator.fork();
unit_generator.set("unit_name:titlecase", title_casify(unit_name));
unit_generator.appendln(" case @dimension_name:titlecase@Unit::@unit_name:titlecase@:");
});
dimension_generator.append(R"~~~(
return true;
default:
return false;
}
};
return is_absolute(a) && is_absolute(b);
}
double ratio_between_units(@dimension_name:titlecase@Unit from, @dimension_name:titlecase@Unit to)
{
if (from == to)