eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibURL+LibWeb+LibWebView: Convert about:version to a proper WebUI

Browse Source 
Passing the browser command line and executable path to every WebContent
process just in case we load about:version always felt a bit weird. We
now use the WebUI framework to load this information on demand.
This commit is contained in:
Timothy Flynn
2026-04-20 17:27:15 -04:00
committed by Tim Flynn
parent 5c835157c6
commit 06796f5f7f
Notes: github-actions[bot] 2026-04-21 11:00:17 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/06796f5f7fa
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/9001
15 changed files with 115 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Services/WebContent/main.cpp
View File

@@ -131,8 +131,6 @@ ErrorOr<int> ladybird_main(Main::Arguments arguments)
Web::Platform::EventLoopPlugin::install(*new Web::Platform::EventLoopPlugin);
StringView command_line {};
StringView executable_path {};
auto config_path = ByteString::formatted("{}/ladybird/default-config", WebView::s_ladybird_resource_root);
StringView mach_server_name {};
Vector<ByteString> certificates;
@@ -154,8 +152,6 @@ ErrorOr<int> ladybird_main(Main::Arguments arguments)
bool file_origins_are_tuple_origins = false;
Core::ArgsParser args_parser;
args_parser.add_option(command_line, "Browser process command line", "command-line", 0, "command_line");
args_parser.add_option(executable_path, "Browser process executable path", "executable-path", 0, "executable_path");
args_parser.add_option(config_path, "Ladybird configuration path", "config-path", 0, "config_path");
args_parser.add_option(enable_test_mode, "Enable test mode", "test-mode");
args_parser.add_option(expose_experimental_interfaces, "Expose experimental IDL interfaces", "expose-experimental-interfaces");
@@ -196,9 +192,6 @@ ErrorOr<int> ladybird_main(Main::Arguments arguments)
}
font_provider.load_all_fonts_from_uri("resource://fonts"sv);
Web::set_browser_process_command_line(command_line);
Web::set_browser_process_executable_path(executable_path);
// Always use the CPU backend for tests, as the GPU backend is not deterministic
if (force_cpu_painting) {
WebContent::PageClient::set_use_skia_painter(WebContent::PageClient::UseSkiaPainter::CPUBackend);