eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-28 10:37:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't cache property accesses on WindowProxy

Browse Source 
Since the underlying HTML::Window can change, caching property accesses
on WindowProxy is not as simple as remembering the shape. Let's disable
caching here for now. We can come back to it in the future when we have
no low-hanging fruit left. :^)

Fixes an assertion failure on https://twinings.co.uk/
This commit is contained in:
Andreas Kling
2023-07-10 20:50:24 +02:00
committed by Linus Groh
parent cf6792ec40
commit 06d9451551
Notes: sideshowbarker 2024-07-18 22:57:59 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/06d9451551
Pull-request: https://github.com/SerenityOS/serenity/pull/19930
Reviewed-by: https://github.com/linusg ✅
3 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
Tests/LibWeb/Text/input/window-proxy-property-inline-cache.html Normal file
View File

@@ -0,0 +1,13 @@
<script src="include.js"></script>
<script>
test(() => {
function ic(o) {
return o.foo
}
window.foo = 123
println(ic(window))
delete window.foo
println(ic(window))
});
</script>