eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't prepare script when src attribute is removed

Browse Source
This commit is contained in:
Tim Ledbetter
2025-02-21 13:23:34 +00:00
committed by Jelle Raaijmakers
parent 63b451cb46
commit 08b5cae199
Notes: github-actions[bot] 2025-02-22 10:40:37 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/08b5cae199d
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3658
Reviewed-by: https://github.com/gmta ✅
3 changed files with 46 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Libraries/LibWeb/HTML/HTMLScriptElement.cpp
View File

@@ -64,6 +64,11 @@ void HTMLScriptElement::attribute_changed(FlyString const& name, Optional<String
if (namespace_.has_value())
return;
// AD-HOC: This ensures that prepare_script() is not called when the src attribute is removed.
// See: https://github.com/whatwg/html/pull/10188/files#r1685905457 for more information.
if (!value.has_value())
return;
// 2. If localName is src, then run the script HTML element post-connection steps, given element.
post_connection();
} else if (name == HTML::AttributeNames::async) {