eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Add SVGImageElement load and error events

Browse Source 
This resolves all WPT timeouts in html/canvas/element/manual/imagebitmap
We can now run an additional 6 tests and 126 subtests :)

This also adds regression tests for this behavior.
This commit is contained in:
Benjamin Bjerken
2024-10-16 16:31:05 +02:00
committed by Tim Ledbetter
parent c097f53875
commit 0c04bd6676
Notes: github-actions[bot] 2024-10-16 22:00:25 +00:00 
Author: https://github.com/beuss-git
Commit: https://github.com/LadybirdBrowser/ladybird/commit/0c04bd66764
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1830
Reviewed-by: https://github.com/AtkinsSJ ✅
3 changed files with 49 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Userland/Libraries/LibWeb/SVG/SVGImageElement.cpp
View File

@@ -9,6 +9,7 @@
#include <LibJS/Heap/Heap.h>
#include <LibWeb/Bindings/SVGImageElementPrototype.h>
#include <LibWeb/DOM/DocumentObserver.h>
#include <LibWeb/DOM/Event.h>
#include <LibWeb/HTML/PotentialCORSRequest.h>
#include <LibWeb/HTML/SharedResourceRequest.h>
#include <LibWeb/Layout/SVGImageBox.h>
@@ -161,9 +162,13 @@ void SVGImageElement::fetch_the_document(URL::URL const& url)
}
set_needs_style_update(true);
document().set_needs_layout();
dispatch_event(DOM::Event::create(realm(), HTML::EventNames::load));
},
[this] {
m_load_event_delayer.clear();
dispatch_event(DOM::Event::create(realm(), HTML::EventNames::error));
});
if (m_resource_request->needs_fetching()) {