eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-03 04:52:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWasm: Use the source_value() mechanism in binary_numeric_operation

Browse Source 
This avoids a bunch of extra stack ops and some unnecessary loads for
registers.
This commit is contained in:
Ali Mohammad Pur
2026-01-28 23:14:20 +01:00
committed by Ali Mohammad Pur
parent 9964c64446
commit 0dc39e9bfd
Notes: github-actions[bot] 2026-02-06 10:42:36 +00:00 
Author: https://github.com/alimpfard
Commit: https://github.com/LadybirdBrowser/ladybird/commit/0dc39e9bfdb
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7477
Reviewed-by: https://github.com/Hendiadyoin1
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Libraries/LibWasm/AbstractMachine/BytecodeInterpreter.cpp
View File

@@ -5398,7 +5398,8 @@ bool BytecodeInterpreter::binary_numeric_operation(Configuration& configuration,
{
// bounds checked by Nor.
auto rhs = configuration.take_source<mix>(0, addresses.sources).template to<PopTypeRHS>();
auto lhs = configuration.take_source<mix>(1, addresses.sources).template to<PopTypeLHS>(); // bounds checked by verifier.
auto& lhs_slot = configuration.source_value<mix>(1, addresses.sources); // bounds checked by verifier.
auto lhs = lhs_slot.template to<PopTypeLHS>();
PushType result;
auto call_result = Operator { forward<Args>(args)... }(lhs, rhs);
if constexpr (IsSpecializationOf<decltype(call_result), AK::ErrorOr>) {
@@ -5409,7 +5410,7 @@ bool BytecodeInterpreter::binary_numeric_operation(Configuration& configuration,
result = call_result;
}
dbgln_if(WASM_TRACE_DEBUG, "{} {} {} = {}", lhs, Operator::name(), rhs, result);
configuration.push_to_destination<mix>(Value(result), addresses.destination);
lhs_slot = Value(result);
return false;
}