eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Make CombineDateAndTimeDuration infallible

Browse Source 
This is an editorial change in the Temporal proposal. See:
https://github.com/tc39/proposal-temporal/commit/794960c
This commit is contained in:
Timothy Flynn
2024-12-05 10:10:39 -05:00
committed by Tim Flynn
parent e29c6d2a80
commit 0e81092685
Notes: github-actions[bot] 2024-12-05 21:06:37 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/0e81092685a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2790
Reviewed-by: https://github.com/gmta ✅
9 changed files with 41 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibJS/Runtime/Temporal/PlainDate.cpp
View File

@@ -365,8 +365,8 @@ ThrowCompletionOr<GC::Ref<Duration>> difference_temporal_plain_date(VM& vm, Dura
// 6. Let dateDifference be CalendarDateUntil(temporalDate.[[Calendar]], temporalDate.[[ISODate]], other.[[ISODate]], settings.[[LargestUnit]]).
auto date_difference = calendar_date_until(vm, temporal_date.calendar(), temporal_date.iso_date(), other->iso_date(), settings.largest_unit);
// 7. Let duration be ! CombineDateAndTimeDuration(dateDifference, 0).
auto duration = MUST(combine_date_and_time_duration(vm, date_difference, TimeDuration { 0 }));
// 7. Let duration be CombineDateAndTimeDuration(dateDifference, 0).
auto duration = combine_date_and_time_duration(date_difference, TimeDuration { 0 });
// 8. If settings.[[SmallestUnit]] is not DAY or settings.[[RoundingIncrement]] ≠ 1, then
if (settings.smallest_unit != Unit::Day || settings.rounding_increment != 1) {