eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Make CombineDateAndTimeDuration infallible

Browse Source 
This is an editorial change in the Temporal proposal. See:
https://github.com/tc39/proposal-temporal/commit/794960c
This commit is contained in:
Timothy Flynn
2024-12-05 10:10:39 -05:00
committed by Tim Flynn
parent e29c6d2a80
commit 0e81092685
Notes: github-actions[bot] 2024-12-05 21:06:37 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/0e81092685a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2790
Reviewed-by: https://github.com/gmta ✅
9 changed files with 41 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibJS/Runtime/Temporal/PlainTime.cpp
View File

@@ -647,8 +647,8 @@ ThrowCompletionOr<GC::Ref<Duration>> difference_temporal_plain_time(VM& vm, Dura
// 5. Set timeDuration to ! RoundTimeDuration(timeDuration, settings.[[RoundingIncrement]], settings.[[SmallestUnit]], settings.[[RoundingMode]]).
time_duration = MUST(round_time_duration(vm, time_duration, Crypto::UnsignedBigInteger { settings.rounding_increment }, settings.smallest_unit, settings.rounding_mode));
// 6. Let duration be ! CombineDateAndTimeDuration(ZeroDateDuration(), timeDuration).
auto duration = MUST(combine_date_and_time_duration(vm, zero_date_duration(vm), move(time_duration)));
// 6. Let duration be CombineDateAndTimeDuration(ZeroDateDuration(), timeDuration).
auto duration = combine_date_and_time_duration(zero_date_duration(vm), move(time_duration));
// 7. Let result be ! TemporalDurationFromInternal(duration, settings.[[LargestUnit]]).
auto result = MUST(temporal_duration_from_internal(vm, duration, settings.largest_unit));