eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS+LibWeb+WebContent: Port JS::PropertyKey to UTF-16

Browse Source 
This has quite a lot of fall out. But the majority of it is just type or
UDL substitution, where the changes just fall through to other function
calls.

By changing property key storage to UTF-16, the main affected areas are:
* NativeFunction names must now be UTF-16
* Bytecode identifiers must now be UTF-16
* Module/binding names must now be UTF-16
This commit is contained in:
Timothy Flynn
2025-08-02 19:27:29 -04:00
committed by Tim Flynn
parent cd276235d7
commit 0efa98a57a
Notes: github-actions[bot] 2025-08-05 11:08:30 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/0efa98a57a5
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5698
131 changed files with 766 additions and 726 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Libraries/LibWeb/HTML/StructuredSerialize.cpp
View File

@@ -223,7 +223,7 @@ static WebIDL::ExceptionOr<void> serialize_viewed_array_buffer(JS::VM& vm, Trans
if constexpr (IsSame<ViewType, JS::DataView>) {
data_holder.encode(ValueTag::ArrayBufferView);
data_holder.append(move(buffer_serialized)); // [[ArrayBufferSerialized]]
data_holder.encode("DataView"_string); // [[Constructor]]
data_holder.encode("DataView"_utf16); // [[Constructor]]
data_holder.encode(JS::get_view_byte_length(view_record));
data_holder.encode(view.byte_offset());
}
@@ -235,8 +235,8 @@ static WebIDL::ExceptionOr<void> serialize_viewed_array_buffer(JS::VM& vm, Trans
// [[ArrayBufferSerialized]]: bufferSerialized, [[ByteLength]]: value.[[ByteLength]],
// [[ByteOffset]]: value.[[ByteOffset]], [[ArrayLength]]: value.[[ArrayLength]] }.
data_holder.encode(ValueTag::ArrayBufferView);
data_holder.append(move(buffer_serialized)); // [[ArrayBufferSerialized]]
data_holder.encode(view.element_name().to_string()); // [[Constructor]]
data_holder.append(move(buffer_serialized)); // [[ArrayBufferSerialized]]
data_holder.encode(view.element_name().to_utf16_string()); // [[Constructor]]
data_holder.encode(JS::typed_array_byte_length(view_record));
data_holder.encode(view.byte_offset());
data_holder.encode(JS::typed_array_length(view_record));
@@ -542,7 +542,7 @@ public:
auto output_value = TRY(structured_serialize_internal(m_vm, input_value, m_for_storage, m_memory));
// 3. Append { [[Key]]: key, [[Value]]: outputValue } to serialized.[[Properties]].
serialized.encode(key.as_string().utf8_string());
serialized.encode(key.as_string().utf16_string());
serialized.append(move(output_value));
++property_count;
@@ -724,7 +724,7 @@ public:
auto array_buffer_value = TRY(deserialize());
auto& array_buffer = as<JS::ArrayBuffer>(array_buffer_value.as_object());
auto constructor_name = m_serialized.decode<String>();
auto constructor_name = m_serialized.decode<Utf16String>();
auto byte_length = m_serialized.decode<u32>();
auto byte_offset = m_serialized.decode<u32>();
@@ -884,7 +884,7 @@ public:
// 1. For each Record { [[Key]], [[Value]] } entry of serialized.[[Properties]]:
for (u64 i = 0u; i < length; ++i) {
auto key = m_serialized.decode<String>();
auto key = m_serialized.decode<Utf16String>();
// 1. Let deserializedValue be ? StructuredDeserialize(entry.[[Value]], targetRealm, memory).
auto deserialized_value = TRY(deserialize());