eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 03:57:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Restrict CSS gap properties to values allowed by the spec

Browse Source 
Gap values are now represented by Variant<LengthPercentage, NormalGap>.
NormalGap is just an empty struct to represent the `normal` keyword.

This fixes a long-standing issue where we were incorrectly storing gaps
as CSS::Size, which led to us allowing a bunch of invalid gap values.
This commit is contained in:
Andreas Kling
2024-11-09 17:38:09 +01:00
committed by Andreas Kling
parent 2a741f81c7
commit 107b20e84d
Notes: github-actions[bot] 2024-11-09 18:23:29 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/107b20e84de
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2253
17 changed files with 157 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Tests/LibWeb/Text/expected/css/getComputedStyle-print-all.txt
View File

@@ -96,7 +96,7 @@ clear: none
clip: auto
clip-path: none
column-count: auto
column-gap: auto
column-gap: normal
column-span: none
column-width: auto
content: normal
@@ -172,7 +172,7 @@ position: static
r: 0px
right: auto
rotate: none
row-gap: auto
row-gap: normal
rx: auto
ry: auto
scrollbar-gutter: auto