eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 18:17:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb+WebContent: Forbid access to underlying type of CSSPixels

Browse Source 
Although DistinctNumeric, which is supposed to abstract the underlying
type, was used to represent CSSPixels, we have a whole bunch of places
in the layout code that assume CSSPixels::value() returns a
floating-point type. This assumption makes it difficult to replace the
underlying type in CSSPixels with a non-floating type.

To make it easier to transition CSSPixels to fixed-point math, one step
we can take is to prevent access to the underlying type using value()
and instead use explicit conversions with the to_float(), to_double(),
and to_int() methods.
This commit is contained in:
Aliaksandr Kalenik
2023-06-12 21:37:35 +03:00
committed by Andreas Kling
parent 5a54c686a7
commit 147c3b3d97
Notes: sideshowbarker 2024-07-17 03:45:48 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/147c3b3d97
Pull-request: https://github.com/SerenityOS/serenity/pull/19368
Reviewed-by: https://github.com/MacDue
43 changed files with 340 additions and 220 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibWeb/SVG/SVGDecodedImageData.cpp
View File

@@ -142,7 +142,7 @@ Optional<float> SVGDecodedImageData::intrinsic_aspect_ratio() const
auto width = intrinsic_width();
auto height = intrinsic_height();
if (width.has_value() && height.has_value())
return (width.value() / height.value()).value();
return width->to_float() / height->to_float();
if (auto const& viewbox = m_root_element->view_box(); viewbox.has_value())
return viewbox->width / viewbox->height;