mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-04-30 19:47:17 +02:00
LibWeb+WebContent: Forbid access to underlying type of CSSPixels
Although DistinctNumeric, which is supposed to abstract the underlying type, was used to represent CSSPixels, we have a whole bunch of places in the layout code that assume CSSPixels::value() returns a floating-point type. This assumption makes it difficult to replace the underlying type in CSSPixels with a non-floating type. To make it easier to transition CSSPixels to fixed-point math, one step we can take is to prevent access to the underlying type using value() and instead use explicit conversions with the to_float(), to_double(), and to_int() methods.
This commit is contained in:
committed by
Andreas Kling
parent
5a54c686a7
commit
147c3b3d97
Notes:
sideshowbarker
2024-07-17 03:45:48 +09:00
Author: https://github.com/kalenikaliaksandr Commit: https://github.com/SerenityOS/serenity/commit/147c3b3d97 Pull-request: https://github.com/SerenityOS/serenity/pull/19368 Reviewed-by: https://github.com/MacDue
@@ -214,7 +214,7 @@ Optional<float> SVGGraphicsElement::stroke_width() const
|
||||
}
|
||||
}
|
||||
auto scaled_viewport_size = (viewport_width + viewport_height) * 0.5;
|
||||
return width->to_px(*layout_node(), scaled_viewport_size).value();
|
||||
return width->to_px(*layout_node(), scaled_viewport_size).to_double();
|
||||
}
|
||||
return {};
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user