eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 12:07:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Invalidate pseudo-elements on hover even when not yet created

Browse Source 
The hover invalidation code only tried matching ::before/::after
selectors when has_pseudo_element() returned true, which requires an
existing layout node. A pseudo-element that doesn't exist yet (because
its content is only set by a hover rule) has no layout node, so the
match was skipped and hovering never triggered a style recompute.
Always try ::before/::after selectors during hover invalidation.
This commit is contained in:
Jelle Raaijmakers
2026-03-24 13:35:58 +01:00
committed by Tim Flynn
parent 77b9fcf7f9
commit 16dffe39a0
Notes: github-actions[bot] 2026-03-24 14:28:09 +00:00 
Author: https://github.com/gmta
Commit: https://github.com/LadybirdBrowser/ladybird/commit/16dffe39a0c
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8605
Reviewed-by: https://github.com/trflynn89 ✅
5 changed files with 43 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
Tests/LibWeb/Text/input/css/pseudo-elements-on-hover.html Normal file
View File

@@ -0,0 +1,36 @@
<!DOCTYPE html>
<style>
.outer {
height: 100px;
}
.update {
display: inline-block;
}
.update::before {
content: "Hi";
}
.outer:hover .update::before {
content: "Long text";
}
.create {
display: inline-block;
}
.outer:hover .create::before {
content: "Flag";
}
</style>
<script src="../include.js"></script>
<div class="outer"><div class="update"></div><div class="create"></div></div>
<script>
test(() => {
const update = document.querySelector('.update');
const create = document.querySelector('.create');
println(`update: ${update.clientWidth} create: ${create.clientWidth}`);
internals.mouseMove(50, 50);
println(`update: ${update.clientWidth} create: ${create.clientWidth}`);
internals.mouseMove(200, 200);
println(`update: ${update.clientWidth} create: ${create.clientWidth}`);
});
</script>