eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Fix "set it to" language to be more explicit

Browse Source 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/de58241
This commit is contained in:
Linus Groh
2022-03-10 17:04:46 +01:00
parent 4722045e28
commit 17da627b4c
Notes: sideshowbarker 2024-07-17 17:36:24 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/17da627b4c
Pull-request: https://github.com/SerenityOS/serenity/pull/12990
Reviewed-by: https://github.com/IdanHo ✅
Reviewed-by: https://github.com/Lubrsi
9 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/Temporal/PlainTime.cpp
View File

@@ -75,7 +75,7 @@ ThrowCompletionOr<PlainTime*> to_temporal_time(GlobalObject& global_object, Valu
{
auto& vm = global_object.vm();
// 1. If overflow is not present, set it to "constrain".
// 1. If overflow is not present, set overflow to "constrain".
if (!overflow.has_value())
overflow = "constrain"sv;
@@ -361,7 +361,7 @@ ThrowCompletionOr<PlainTime*> create_temporal_time(GlobalObject& global_object,
if (!is_valid_time(hour, minute, second, millisecond, microsecond, nanosecond))
return vm.throw_completion<RangeError>(global_object, ErrorType::TemporalInvalidPlainTime);
// 3. If newTarget is not present, set it to %Temporal.PlainTime%.
// 3. If newTarget is not present, set newTarget to %Temporal.PlainTime%.
if (!new_target)
new_target = global_object.temporal_plain_time_constructor();
@@ -533,7 +533,7 @@ DaysAndTime round_time(u8 hour, u8 minute, u8 second, u16 millisecond, u16 micro
// 3. If unit is "day", then
if (unit == "day"sv) {
// a. If dayLengthNs is not present, set it to 8.64 × 10^13.
// a. If dayLengthNs is not present, set dayLengthNs to 8.64 × 10^13.
if (!day_length_ns.has_value())
day_length_ns = 86400000000000;