eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Suppress rendering due to view transitions

Browse Source 
This also fixes a bug in the view transitions code that was
required to get the imported test to pass. The code for setting
the initial containing block size just did not set the right thing,
since doing so would trigger an error later on.

That later error resulted from walking up the tree, without
considering that the document element has a parent that is not
itself an element. (and then doing element things to it)
This commit is contained in:
Psychpsyo
2025-09-09 09:45:52 +02:00
committed by Jelle Raaijmakers
parent 18cf540bfb
commit 17e5289524
Notes: github-actions[bot] 2025-09-09 08:26:40 +00:00 
Author: https://github.com/Psychpsyo
Commit: https://github.com/LadybirdBrowser/ladybird/commit/17e5289524f
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6135
Reviewed-by: https://github.com/gmta ✅
7 changed files with 412 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/HTML/Navigable.cpp
View File

@@ -2456,11 +2456,9 @@ bool Navigable::has_a_rendering_opportunity() const
// accounting for hardware refresh rate constraints and user agent throttling for performance reasons,
// but considering content presentable even if it's outside the viewport.
// A navigable has no rendering opportunities if its active document is render-blocked
// or if it is suppressed for view transitions;
// otherwise, rendering opportunities are determined based on hardware constraints
// A navigable's rendering opportunities are determined based on hardware constraints
// such as display refresh rates and other factors such as page performance
// or whether the document's visibility state is "visible".
// or whether its active document's visibility state is "visible".
// Rendering opportunities typically occur at regular intervals.
// FIXME: Return `false` here if we're an inactive browser tab.