eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Make Cell::initialize() return void

Browse Source 
Stop worrying about tiny OOMs.

Work towards #20405
This commit is contained in:
Andreas Kling
2023-08-07 08:41:28 +02:00
parent fde26c53f0
commit 18c54d8d40
Notes: sideshowbarker 2024-07-17 05:09:48 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/18c54d8d40
Pull-request: https://github.com/SerenityOS/serenity/pull/20420
804 changed files with 1330 additions and 2171 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Userland/Libraries/LibJS/Runtime/ShadowRealmConstructor.cpp
View File

@@ -16,17 +16,15 @@ ShadowRealmConstructor::ShadowRealmConstructor(Realm& realm)
{
}
ThrowCompletionOr<void> ShadowRealmConstructor::initialize(Realm& realm)
void ShadowRealmConstructor::initialize(Realm& realm)
{
auto& vm = this->vm();
MUST_OR_THROW_OOM(NativeFunction::initialize(realm));
Base::initialize(realm);
// 3.3.1 ShadowRealm.prototype, https://tc39.es/proposal-shadowrealm/#sec-shadowrealm.prototype
define_direct_property(vm.names.prototype, realm.intrinsics().shadow_realm_prototype(), 0);
define_direct_property(vm.names.length, Value(0), Attribute::Configurable);
return {};
}
// 3.2.1 ShadowRealm ( ), https://tc39.es/proposal-shadowrealm/#sec-shadowrealm
@@ -70,7 +68,7 @@ ThrowCompletionOr<NonnullGCPtr<Object>> ShadowRealmConstructor::construct(Functi
auto& global_object = set_default_global_bindings(object->shadow_realm());
// FIXME: 12. Perform ? HostInitializeShadowRealm(O.[[ShadowRealm]]).
MUST_OR_THROW_OOM(global_object.initialize(object->shadow_realm()));
global_object.initialize(object->shadow_realm());
// 13. Return O.
return object;