eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 18:17:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibXML+LibWeb: Use existing HTML entities table for XML parsing too

Browse Source 
For XHTML documents, resolve named character entities (e.g.,  )
using the HTML entity table via a getEntity SAX callback. This avoids
parsing a large embedded DTD on every document and matches the approach
used by Blink and WebKit.

This also removes the now-unused DTD infrastructure:

- Remove resolve_external_resource callback from Parser::Options
- Remove resolve_xml_resource() function and its ~60KB embedded DTD
- Remove all call sites passing the unused callback
This commit is contained in:
sideshowbarker
2026-01-09 04:32:12 +09:00
committed by Tim Ledbetter
parent 35bb1e20ee
commit 1b41659efd
Notes: github-actions[bot] 2026-01-09 19:14:36 +00:00 
Author: https://github.com/sideshowbarker
Commit: https://github.com/LadybirdBrowser/ladybird/commit/1b41659efd2
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7375
Reviewed-by: https://github.com/alimpfard ✅
Reviewed-by: https://github.com/gmta
Reviewed-by: https://github.com/tcl3 ✅
43 changed files with 28321 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Tests/LibWeb/Ref/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/adopt-while-parsing-001-ref.html Normal file
View File

@@ -0,0 +1,9 @@
<!doctype html>
<title>Test reference</title>
<style>
html, body { margin: 0 }
</style>
<iframe src="about:blank"></iframe>
<div>
PASS
</div>

4
Tests/LibWeb/Ref/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/data-xhtml-with-dtd-ref.html Normal file
View File

@@ -0,0 +1,4 @@
<!DOCTYPE html>
Test passes if it correctly shows &Aacute; in the subframe.
<hr>
<iframe srcdoc="&amp;Aacute"></iframe>