eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 09:45:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibXML+LibWeb: Use existing HTML entities table for XML parsing too

Browse Source 
For XHTML documents, resolve named character entities (e.g.,  )
using the HTML entity table via a getEntity SAX callback. This avoids
parsing a large embedded DTD on every document and matches the approach
used by Blink and WebKit.

This also removes the now-unused DTD infrastructure:

- Remove resolve_external_resource callback from Parser::Options
- Remove resolve_xml_resource() function and its ~60KB embedded DTD
- Remove all call sites passing the unused callback
This commit is contained in:
sideshowbarker
2026-01-09 04:32:12 +09:00
committed by Tim Ledbetter
parent 35bb1e20ee
commit 1b41659efd
Notes: github-actions[bot] 2026-01-09 19:14:36 +00:00 
Author: https://github.com/sideshowbarker
Commit: https://github.com/LadybirdBrowser/ladybird/commit/1b41659efd2
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7375
Reviewed-by: https://github.com/alimpfard ✅
Reviewed-by: https://github.com/gmta
Reviewed-by: https://github.com/tcl3 ✅
43 changed files with 28321 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2130
Tests/LibWeb/Text/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-1.txt Normal file
View File

File diff suppressed because it is too large Load Diff

2236
Tests/LibWeb/Text/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-10.txt Normal file
View File

File diff suppressed because it is too large Load Diff

2130
Tests/LibWeb/Text/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-11.txt Normal file
View File

File diff suppressed because it is too large Load Diff

2130
Tests/LibWeb/Text/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-12.txt Normal file
View File

File diff suppressed because it is too large Load Diff

2130
Tests/LibWeb/Text/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-2.txt Normal file
View File

File diff suppressed because it is too large Load Diff

2130
Tests/LibWeb/Text/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-3.txt Normal file
View File

File diff suppressed because it is too large Load Diff

2130
Tests/LibWeb/Text/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-4.txt Normal file
View File

File diff suppressed because it is too large Load Diff

2130
Tests/LibWeb/Text/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-5.txt Normal file
View File

File diff suppressed because it is too large Load Diff

2130
Tests/LibWeb/Text/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-6.txt Normal file
View File

File diff suppressed because it is too large Load Diff

2130
Tests/LibWeb/Text/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-7.txt Normal file
View File

File diff suppressed because it is too large Load Diff

2130
Tests/LibWeb/Text/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-8.txt Normal file
View File

File diff suppressed because it is too large Load Diff

2130
Tests/LibWeb/Text/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-9.txt Normal file
View File

File diff suppressed because it is too large Load Diff

6
Tests/LibWeb/Text/expected/wpt-import/html/the-xhtml-syntax/parsing-xhtml-documents/xml-stylesheet-blocking.txt Normal file
View File

@@ -0,0 +1,6 @@
Harness status: OK
Found 1 tests
1 Fail
Fail xml-stylesheet blocks script execution and rendering