eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-28 10:37:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/HTML: Update get_an_elements_noopener() to current spec

Browse Source 
Note that this preemptively includes this fix to step 3:
https://github.com/whatwg/html/pull/10962
This commit is contained in:
Sam Atkins
2025-01-29 16:56:55 +00:00
committed by Tim Ledbetter
parent 6bc38832af
commit 1bd73184da
Notes: github-actions[bot] 2025-01-31 17:28:04 +00:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/LadybirdBrowser/ladybird/commit/1bd73184da7
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3402
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/shannonbooth
Reviewed-by: https://github.com/tcl3 ✅
7 changed files with 25 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLHyperlinkElementUtils.cpp
View File

@@ -488,7 +488,7 @@ void HTMLHyperlinkElementUtils::follow_the_hyperlink(Optional<String> hyperlink_
return;
// 6. Let noopener be the result of getting an element's noopener with subject, urlRecord, and targetAttributeValue.
auto noopener = hyperlink_element_utils_get_an_elements_noopener(target_attribute_value);
auto noopener = hyperlink_element_utils_get_an_elements_noopener(*url_record, target_attribute_value);
// 7. Let targetNavigable be the first return value of applying the rules for choosing a navigable given
// targetAttributeValue, subject's node navigable, and noopener.