eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Port EventLoop::spin_XXX to HeapFunction

Browse Source
This commit is contained in:
Shannon Booth
2024-10-31 05:23:43 +13:00
committed by Alexander Kalenik
parent 29cea5bd24
commit 1c18b900e2
Notes: github-actions[bot] 2024-10-30 19:57:02 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/1c18b900e28
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2062
Reviewed-by: https://github.com/kalenikaliaksandr ✅
14 changed files with 68 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
Userland/Libraries/LibWeb/XML/XMLDocumentBuilder.cpp
View File

@@ -177,9 +177,9 @@ void XMLDocumentBuilder::element_end(const XML::Name& name)
// 2. Spin the event loop until the parser's Document has no style sheet that is blocking scripts and the pending parsing-blocking script's "ready to be parser-executed" flag is set.
if (m_document->has_a_style_sheet_that_is_blocking_scripts() || !pending_parsing_blocking_script->is_ready_to_be_parser_executed()) {
HTML::main_thread_event_loop().spin_until([&] {
HTML::main_thread_event_loop().spin_until(JS::create_heap_function(script_element.heap(), [&] {
return !m_document->has_a_style_sheet_that_is_blocking_scripts() && pending_parsing_blocking_script->is_ready_to_be_parser_executed();
});
}));
}
// 3. Unblock this instance of the XML parser, such that tasks that invoke it can again be run.
@@ -231,6 +231,8 @@ void XMLDocumentBuilder::comment(StringView data)
void XMLDocumentBuilder::document_end()
{
auto& heap = m_document->heap();
// When an XML parser reaches the end of its input, it must stop parsing.
// If the active speculative HTML parser is not null, then stop the speculative HTML parser and return.
// NOTE: Noop.
@@ -248,10 +250,10 @@ void XMLDocumentBuilder::document_end()
while (!m_document->scripts_to_execute_when_parsing_has_finished().is_empty()) {
// Spin the event loop until the first script in the list of scripts that will execute when the document has finished parsing has its "ready to be parser-executed" flag set
// and the parser's Document has no style sheet that is blocking scripts.
HTML::main_thread_event_loop().spin_until([&] {
HTML::main_thread_event_loop().spin_until(JS::create_heap_function(heap, [&] {
return m_document->scripts_to_execute_when_parsing_has_finished().first()->is_ready_to_be_parser_executed()
&& !m_document->has_a_style_sheet_that_is_blocking_scripts();
});
}));
// Execute the first script in the list of scripts that will execute when the document has finished parsing.
m_document->scripts_to_execute_when_parsing_has_finished().first()->execute_script();
@@ -278,14 +280,14 @@ void XMLDocumentBuilder::document_end()
}));
// Spin the event loop until the set of scripts that will execute as soon as possible and the list of scripts that will execute in order as soon as possible are empty.
HTML::main_thread_event_loop().spin_until([&] {
HTML::main_thread_event_loop().spin_until(JS::create_heap_function(heap, [&] {
return m_document->scripts_to_execute_as_soon_as_possible().is_empty();
});
}));
// Spin the event loop until there is nothing that delays the load event in the Document.
HTML::main_thread_event_loop().spin_until([&] {
HTML::main_thread_event_loop().spin_until(JS::create_heap_function(heap, [&] {
return !m_document->anything_is_delaying_the_load_event();
});
}));
// Queue a global task on the DOM manipulation task source given the Document's relevant global object to run the following steps:
queue_global_task(HTML::Task::Source::DOMManipulation, m_document, JS::create_heap_function(m_document->heap(), [document = m_document] {