eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

WebContent: Combine viewport size and DPR into a single IPC message

Browse Source 
The set_viewport_size and set_device_pixel_ratio IPC messages were sent
separately, potentially causing a race condition when the DPR changes
(e.g. moving a window between screens): the DPR message would arrive
and use a stale viewport size, computing a temporarily wrong CSS
viewport. Combine both into a single set_viewport IPC that updates the
device viewport size and DPR together.
This commit is contained in:
Jelle Raaijmakers
2026-02-20 22:09:39 +01:00
committed by Jelle Raaijmakers
parent 15e784cc4f
commit 1cc29c669a
Notes: github-actions[bot] 2026-02-23 14:23:29 +00:00 
Author: https://github.com/gmta
Commit: https://github.com/LadybirdBrowser/ladybird/commit/1cc29c669a6
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8054
13 changed files with 31 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibWebView/ViewImplementation.cpp
View File

@@ -613,7 +613,7 @@ void ViewImplementation::update_zoom()
void ViewImplementation::handle_resize()
{
client().async_set_viewport_size(page_id(), this->viewport_size());
client().async_set_viewport(page_id(), this->viewport_size(), m_device_pixel_ratio);
}
void ViewImplementation::initialize_client(CreateNewClient create_new_client)
@@ -630,7 +630,7 @@ void ViewImplementation::initialize_client(CreateNewClient create_new_client)
m_client_state.client_handle = MUST(Web::Crypto::generate_random_uuid());
client().async_set_window_handle(m_client_state.page_index, m_client_state.client_handle);
client().async_set_zoom_level(m_client_state.page_index, m_zoom_level);
client().async_set_device_pixel_ratio(m_client_state.page_index, m_device_pixel_ratio);
client().async_set_viewport(m_client_state.page_index, viewport_size(), m_device_pixel_ratio);
client().async_set_maximum_frames_per_second(m_client_state.page_index, m_maximum_frames_per_second);
client().async_set_system_visibility_state(m_client_state.page_index, m_system_visibility_state);
client().async_set_document_cookie_version_buffer(m_client_state.page_index, m_document_cookie_version_buffer);