eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Deduplicate "ident is color" check

Browse Source 
Reuse the check from IdentifierStyleValue in the CSS Parser, instead of
duplicating it. This might not be the ideal place to put it, but it
works for now.
This commit is contained in:
Sam Atkins
2023-08-23 15:40:17 +01:00
committed by Sam Atkins
parent da8692572a
commit 1dcd63be05
Notes: sideshowbarker 2024-07-16 22:54:10 +09:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/SerenityOS/serenity/commit/1dcd63be05
Pull-request: https://github.com/SerenityOS/serenity/pull/20743
3 changed files with 11 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Userland/Libraries/LibWeb/CSS/StyleValues/IdentifierStyleValue.cpp
View File

@@ -19,9 +19,9 @@ String IdentifierStyleValue::to_string() const
return MUST(String::from_utf8(CSS::string_from_value_id(m_id)));
}
bool IdentifierStyleValue::has_color() const
bool IdentifierStyleValue::is_color(ValueID value_id)
{
switch (m_id) {
switch (value_id) {
case ValueID::Currentcolor:
case ValueID::LibwebLink:
case ValueID::LibwebPaletteActiveLink:
@@ -84,6 +84,11 @@ bool IdentifierStyleValue::has_color() const
}
}
bool IdentifierStyleValue::has_color() const
{
return is_color(m_id);
}
Color IdentifierStyleValue::to_color(Optional<Layout::NodeWithStyle const&> node) const
{
if (id() == CSS::ValueID::Currentcolor) {