eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

KeyboardSettings: Fix adding empty keymaps

Browse Source 
In the Keymap Settings dialog, a check was missing when the Keymap
selection dialog was cancelled.

Not checking the return value causes an empty string to be added to
the keymap list.
This commit is contained in:
Thomas
2022-03-01 17:35:16 +01:00
committed by Andreas Kling
parent 451fee8fd7
commit 1e31c1260a
Notes: sideshowbarker 2024-07-19 17:08:02 +09:00 
Author: https://github.com/tsymalla 🔰
Commit: https://github.com/SerenityOS/serenity/commit/1e31c1260a7
Pull-request: https://github.com/SerenityOS/serenity/pull/12831
Reviewed-by: https://github.com/bgianfo
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Userland/Applications/KeyboardSettings/KeyboardSettingsWidget.cpp
View File

@@ -163,7 +163,8 @@ KeyboardSettingsWidget::KeyboardSettingsWidget()
m_add_keymap_button->on_click = [&](auto) {
auto keymap = KeymapSelectionDialog::select_keymap(window(), keymaps_list_model.keymaps());
keymaps_list_model.add_keymap(keymap);
if (!keymap.is_empty())
keymaps_list_model.add_keymap(keymap);
};
m_remove_keymap_button = find_descendant_of_type_named<GUI::Button>("remove_keymap_button");