eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 11:37:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Support the exporting of ml-dsa keys in jwk format

Browse Source
This commit is contained in:
Tete17
2025-11-24 01:13:43 +01:00
committed by Jelle Raaijmakers
parent a5e037e2af
commit 2078317a51
Notes: github-actions[bot] 2025-12-10 20:28:12 +00:00 
Author: https://github.com/tete17
Commit: https://github.com/LadybirdBrowser/ladybird/commit/2078317a512
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6935
Reviewed-by: https://github.com/R-Goc
Reviewed-by: https://github.com/gmta ✅
1 changed files with 40 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
Libraries/LibWeb/Crypto/CryptoAlgorithms.cpp
View File

@@ -8754,7 +8754,46 @@ WebIDL::ExceptionOr<GC::Ref<JS::Object>> MLDSA::export_key(Bindings::KeyFormat f
// 3. Let result be data.
result = JS::ArrayBuffer::create(m_realm, data);
}
// FIXME -> If format is "jwk":
// -> If format is "jwk":
else if (format == Bindings::KeyFormat::Jwk) {
// 1. Let jwk be a new JsonWebKey dictionary.
auto jwk = Bindings::JsonWebKey {};
// 2. Set the kty attribute of jwk to "AKP".
jwk.kty = "AKP"_string;
// 3. Set the alg attribute of jwk to the name member of normalizedAlgorithm.
jwk.alg = key->algorithm_name();
// 4. Set the pub attribute of jwk to the base64url encoded public key corresponding to the [[handle]] internal slot of key.
jwk.pub = TRY_OR_THROW_OOM(
vm,
encode_base64url(handle.visit(
[](::Crypto::PK::MLDSAPublicKey const& public_key) -> ByteBuffer { return public_key.public_key(); },
[](::Crypto::PK::MLDSAPrivateKey const& private_key) -> ByteBuffer { return private_key.public_key(); },
[](auto) -> ByteBuffer { VERIFY_NOT_REACHED(); }),
AK::OmitPadding::Yes));
// 5. -> If the [[type]] internal slot of key is "private":
// Set the priv attribute of jwk to the base64url encoded seed represented by the [[handle]] internal slot of key.
if (key->type() == Bindings::KeyType::Private) {
VERIFY(handle.has<::Crypto::PK::MLDSAPrivateKey>());
jwk.priv = TRY_OR_THROW_OOM(vm, encode_base64url(handle.get<::Crypto::PK::MLDSAPrivateKey>().seed(), AK::OmitPadding::Yes));
}
// 6. Set the key_ops attribute of jwk to the usages attribute of key.
jwk.key_ops = Vector<String> {};
jwk.key_ops->ensure_capacity(key->internal_usages().size());
for (auto const& usage : key->internal_usages()) {
jwk.key_ops->append(Bindings::idl_enum_to_string(usage));
}
// 7. Set the ext attribute of jwk to the [[extractable]] internal slot of key.
jwk.ext = key->extractable();
// 8. Let result be jwk.
result = TRY(jwk.to_object(m_realm));
}
// -> Otherwise:
else {
// throw a NotSupportedError.