eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-09 16:42:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Merge did_remove_attribute() into attribute_changed()

Browse Source 
Instead of having two virtuals for attribute change notifications,
there is now only one. When the attribute is removed, the value is null.
This commit is contained in:
Andreas Kling
2023-07-03 17:31:17 +02:00
parent 5a74486b59
commit 21260ea2ef
Notes: sideshowbarker 2024-07-17 02:55:44 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/21260ea2ef
Pull-request: https://github.com/SerenityOS/serenity/pull/19772
18 changed files with 86 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
Userland/Libraries/LibWeb/HTML/HTMLScriptElement.cpp
View File

@@ -51,20 +51,17 @@ void HTMLScriptElement::attribute_changed(DeprecatedFlyString const& name, Depre
{
Base::attribute_changed(name, value);
if (name == HTML::AttributeNames::crossorigin)
m_crossorigin = cors_setting_attribute_from_keyword(String::from_deprecated_string(value).release_value_but_fixme_should_propagate_errors());
else if (name == HTML::AttributeNames::referrerpolicy)
m_referrer_policy = ReferrerPolicy::from_string(value);
}
void HTMLScriptElement::did_remove_attribute(DeprecatedFlyString const& name)
{
Base::did_remove_attribute(name);
if (name == HTML::AttributeNames::crossorigin)
m_crossorigin = cors_setting_attribute_from_keyword({});
else if (name == HTML::AttributeNames::referrerpolicy)
m_referrer_policy.clear();
if (name == HTML::AttributeNames::crossorigin) {
if (value.is_null())
m_crossorigin = cors_setting_attribute_from_keyword({});
else
m_crossorigin = cors_setting_attribute_from_keyword(String::from_deprecated_string(value).release_value_but_fixme_should_propagate_errors());
} else if (name == HTML::AttributeNames::referrerpolicy) {
if (value.is_null())
m_referrer_policy.clear();
else
m_referrer_policy = ReferrerPolicy::from_string(value);
}
}
void HTMLScriptElement::begin_delaying_document_load_event(DOM::Document& document)