eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibGfx+LibWeb: Move Skia backend context to process level singleton

Browse Source 
Previously, this was attached to the traversable navigable. Using a
singleton instead allows us to use the context for detached documents.
This commit is contained in:
Tim Ledbetter
2026-03-16 23:55:40 +00:00
committed by Jelle Raaijmakers
parent d4cf537d58
commit 26389363ad
Notes: github-actions[bot] 2026-03-19 12:36:24 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/26389363ad2
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8460
Reviewed-by: https://github.com/gmta ✅
18 changed files with 90 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
Libraries/LibWeb/HTML/Navigable.cpp
View File

@@ -145,28 +145,6 @@ bool Navigable::is_ancestor_of(GC::Ref<Navigable> other) const
return false;
}
static RefPtr<Gfx::SkiaBackendContext> g_cached_skia_backend_context;
static RefPtr<Gfx::SkiaBackendContext> get_skia_backend_context()
{
if (!g_cached_skia_backend_context) {
#ifdef AK_OS_MACOS
auto metal_context = Gfx::get_metal_context();
g_cached_skia_backend_context = Gfx::SkiaBackendContext::create_metal_context(*metal_context);
#elif USE_VULKAN
auto maybe_vulkan_context = Gfx::create_vulkan_context();
if (maybe_vulkan_context.is_error()) {
dbgln("Vulkan context creation failed: {}", maybe_vulkan_context.error());
return {};
}
auto vulkan_context = maybe_vulkan_context.release_value();
g_cached_skia_backend_context = Gfx::SkiaBackendContext::create_vulkan_context(vulkan_context);
#endif
}
return g_cached_skia_backend_context;
}
Navigable::Navigable(GC::Ref<Page> page, bool is_svg_page)
: m_page(page)
, m_event_handler({}, *this)
@@ -179,19 +157,9 @@ Navigable::Navigable(GC::Ref<Page> page, bool is_svg_page)
{
all_navigables().set(*this);
auto display_list_player_type = page->client().display_list_player_type();
if (display_list_player_type == DisplayListPlayerType::SkiaGPUIfAvailable) {
m_skia_backend_context = get_skia_backend_context();
}
if (!m_is_svg_page) {
OwnPtr<Painting::DisplayListPlayerSkia> skia_player;
if (display_list_player_type == DisplayListPlayerType::SkiaGPUIfAvailable) {
skia_player = make<Painting::DisplayListPlayerSkia>(m_skia_backend_context);
} else {
skia_player = make<Painting::DisplayListPlayerSkia>();
}
m_rendering_thread.set_skia_player(move(skia_player));
auto display_list_player_type = page->client().display_list_player_type();
m_rendering_thread.set_skia_player(make<Painting::DisplayListPlayerSkia>());
m_rendering_thread.start(display_list_player_type);
}
}
@@ -2911,11 +2879,6 @@ void Navigable::render_screenshot(Gfx::PaintingSurface& painting_surface, PaintC
m_rendering_thread.request_screenshot(painting_surface, move(callback));
}
RefPtr<Gfx::SkiaBackendContext> Navigable::skia_backend_context() const
{
return m_skia_backend_context;
}
GC::Ref<WebIDL::Promise> Navigable::scroll_viewport_by_delta(CSSPixelPoint delta)
{
auto vv = active_document()->visual_viewport();