eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 12:07:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Update fallibility of ParseISODateTime in spec comments

Browse Source 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/bc79069
This commit is contained in:
Linus Groh
2022-02-04 19:17:06 +00:00
parent 6df246091b
commit 28ac5a1333
Notes: sideshowbarker 2024-07-17 19:47:52 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/28ac5a1333d
Pull-request: https://github.com/SerenityOS/serenity/pull/12284
Reviewed-by: https://github.com/IdanHo ✅
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp
View File

@@ -1241,8 +1241,7 @@ ThrowCompletionOr<TemporalInstant> parse_temporal_instant_string(GlobalObject& g
return vm.throw_completion<RangeError>(global_object, ErrorType::TemporalInvalidInstantString, iso_string);
}
// 3. Let result be ! ParseISODateTime(isoString).
// NOTE: !/? confusion is a spec issue. See: https://github.com/tc39/proposal-temporal/pull/2027
// 3. Let result be ? ParseISODateTime(isoString).
auto result = TRY(parse_iso_date_time(global_object, *parse_result));
// 4. Let timeZoneResult be ? ParseTemporalTimeZoneString(isoString).
@@ -1278,8 +1277,7 @@ ThrowCompletionOr<TemporalZonedDateTime> parse_temporal_zoned_date_time_string(G
return vm.throw_completion<RangeError>(global_object, ErrorType::TemporalInvalidZonedDateTimeString, iso_string);
}
// 3. Let result be ! ParseISODateTime(isoString).
// NOTE: !/? confusion is a spec issue. See: https://github.com/tc39/proposal-temporal/pull/2027
// 3. Let result be ? ParseISODateTime(isoString).
auto result = TRY(parse_iso_date_time(global_object, *parse_result));
// 4. Let timeZoneResult be ? ParseTemporalTimeZoneString(isoString).
@@ -1561,8 +1559,7 @@ ThrowCompletionOr<TemporalZonedDateTime> parse_temporal_relative_to_string(Globa
return vm.throw_completion<RangeError>(global_object, ErrorType::TemporalInvalidRelativeToString, iso_string);
}
// 3. Let result be ! ParseISODateTime(isoString).
// NOTE: !/? confusion is a spec issue. See: https://github.com/tc39/proposal-temporal/pull/2027
// 3. Let result be ? ParseISODateTime(isoString).
auto result = TRY(parse_iso_date_time(global_object, *parse_result));
bool z;